Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80504
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender)
MIME-Version: 1.0
Reply-To: marcio3w@gmail.com
Date: Wed, 14 Jan 2015 20:33:35 -0300
Message-ID: <CAOsHV+t7RtzKfivCYcSFEzjEHtqwneR7gvtppA9SvYW88ULJFw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133a5744d606e050ca52cc6
Subject: [PHP_DEV] Possible RFC
From: marcio.web2@gmail.com (Marcio Almada)

--001a1133a5744d606e050ca52cc6
Content-Type: text/plain; charset=UTF-8

Hi,

I'd like to propose an RFC to convert PCRE compilation E_WARNINGs to
E_RECOVERABLE_ERRORs, so I'm opening a prior discussion to see how viable
this could be.

The reason is quite simple. If userland code is using malformed regular
expressions, this is probably a programmer's mistake caused by lack of
attention or lack of knowledge about PCRE flavor. In any case, program
execution should be halted because the given regular expression is not
working as expected.

Consider the following (lame) code example:

    function securityCheck($input) {
        if (! preg_match('/some malformed regex', $input))
            throw new Exception("Dangerous user input!");
        }
    }

    // the regexp is malformed so
    // none of the following calls will throw exception :(
    securityCheck($good_input);
    securityCheck($danger_input);


This could cause a minor BC break for programs already running with
malformed regexp, but that's the hole purpose of this discussion. Do you
think such RFC would be a good idea?


Regards,
Marcio Almada.

--001a1133a5744d606e050ca52cc6--