Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80486
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.180 as permitted sender)
Message-ID: <54B6CD05.3070005@gmail.com>
Date: Wed, 14 Jan 2015 12:09:41 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Xinchen Hui <laruence@php.net>, 
 PHP Internals <internals@lists.php.net>,
 Dmitry Stogov <dmitry@zend.com>, Nikita Popov <nikita.ppv@gmail.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com> <CABBJUpfWmJGDvmKASKnukQEfDSP7L6UaHO10UoRQ3VRbvPwJvA@mail.gmail.com>
In-Reply-To: <CABBJUpfWmJGDvmKASKnukQEfDSP7L6UaHO10UoRQ3VRbvPwJvA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Faster zend sorting implementation
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

>     I made a PR here: https://github.com/php/php-src/pull/999 for reviewing
> 
>     in benchmark this can brings more than 30% performance gain in
> array_sort etc functions.
> 
>     tests fails are related to non-stable vs stable sorting difference.
> 
>     anyway, I feel it's better to ask you to do a final review, what
> do you think?
> 
>     is there any objections to merge this?

I think the sort order of equal elements was never defined, so changing
it would not be a big issue. The tests, of course, need to be fixed and
note in UPGRADING should be provided, but otherwise it's fine.

-- 
Stas Malyshev
smalyshev@gmail.com