Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80463
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpfWmJGDvmKASKnukQEfDSP7L6UaHO10UoRQ3VRbvPwJvA@mail.gmail.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
	<CABBJUpfWmJGDvmKASKnukQEfDSP7L6UaHO10UoRQ3VRbvPwJvA@mail.gmail.com>
Date: Wed, 14 Jan 2015 17:52:46 +0400
Message-ID: <CA+9eiLtZOxcYwFgn5a+J=SsdzEDJsFfkB5qpavcp3nFQeuA0pA@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c2c67ae806fe050c9d0d39
Subject: Re: Faster zend sorting implementation
From: dmitry@zend.com (Dmitry Stogov)

--001a11c2c67ae806fe050c9d0d39
Content-Type: text/plain; charset=UTF-8

I don't see big problems committing this.
In some cases new sort() functions may provide different results, but they
are still valid, because the order of "equal" elements after sort is not
defined.

Thanks. Dmitry.

On Wed, Jan 14, 2015 at 12:59 PM, Xinchen Hui <laruence@php.net> wrote:

> Hey:
>
>     I made a PR here: https://github.com/php/php-src/pull/999 for
> reviewing
>
>     in benchmark this can brings more than 30% performance gain in
> array_sort etc functions.
>
>     tests fails are related to non-stable vs stable sorting difference.
>
>     anyway, I feel it's better to ask you to do a final review, what
> do you think?
>
>     is there any objections to merge this?
>
> thanks
>
> On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui <laruence@php.net> wrote:
> > Hey:
> >
> >      I was working on zend_qsort improvement. but I got a problem need
> > to be disscussed with you fist..
> >
> >      as we know,  previously zend_qsort is not a stable sorting algo.
> >
> >      my draft patch (which already get 0.1% IRs reduce in wordpress)
> > is kindof a stable sorting algo, you can find it here
> > (https://github.com/laruence/php-src/compare/zend_sort)
> >
> >      so, there is a bc break, like for :
> >
> >      $array = array("o",  "O");
> >      sort($array, SORT_STRING|SORT_FLAG_CASE);
> >
> >      var_dump($array);
> >
> >      previously implementation does the swap:
> >
> > array(2) {
> >   [0]=>
> >   string(1) "O"
> >   [1]=>
> >   string(1) "o"
> > }
> >
> >      but new implementation doesn't not:
> >
> > array(2) {
> >   [0]=>
> >   string(1) "o"
> >   [1]=>
> >   string(1) "O"
> > }
> >
> >     do you think such BC break is acceptable? or I still need a RFC? :<
> >
> > thanks
> > --
> > Xinchen Hui
> > @Laruence
> > http://www.laruence.com/
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--001a11c2c67ae806fe050c9d0d39--