Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80438
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nHCi3hhmQ3h9AgKj4OOSx+DCRy7ZPGUA8+=aUG5dB782A@mail.gmail.com>
References: <CAAyV7nHCi3hhmQ3h9AgKj4OOSx+DCRy7ZPGUA8+=aUG5dB782A@mail.gmail.com>
Date: Tue, 13 Jan 2015 09:09:37 +0000
Message-ID: <CAPwsocG6kC-5e=Srbwya+N0_h7aHT6DLWpF-sstn2dvd3FFu1g@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Crypt Warnings (was PHP 5.5.21RC1 is ready for testing)
From: leight@gmail.com (Leigh)

On 9 January 2015 at 16:45, Anthony Ferrara <ircmaxell@gmail.com> wrote:
>
> Changing this fallback behavior to the correct error should happen.
> However, this will likely break a number of live systems which are
> currently relying on the incorrect behavior (likely without knowing
> it).

I'd call this a sec fix. Absolutely preferable to have an error than a
silent fallback to broken crypto.

>
> Then in a future version (7.1, 8, whatever) remove the fallback and
> keep the error along with returning a failure indication (*0).
>

Is 7 really too soon? I know we err on the side of compatibility, but
in my opinion the fallback should be removed completely (any salt
starting with a $ must not degrade to any other method).