Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80426
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.52 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAAyV7nHCi3hhmQ3h9AgKj4OOSx+DCRy7ZPGUA8+=aUG5dB782A@mail.gmail.com>
References: <CAAyV7nHCi3hhmQ3h9AgKj4OOSx+DCRy7ZPGUA8+=aUG5dB782A@mail.gmail.com>
Date: Tue, 13 Jan 2015 09:51:43 +0900
Message-ID: <CAGa2bXYN3RmOKRmzD8uX+2tuukGgMM2W7gwoFXqOro_h-cv_9A@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c2c72c3d776c050c7e0989
Subject: Re: [PHP-DEV] Crypt Warnings (was PHP 5.5.21RC1 is ready for testing)
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c2c72c3d776c050c7e0989
Content-Type: text/plain; charset=UTF-8

Hi all,

On Sat, Jan 10, 2015 at 1:45 AM, Anthony Ferrara <ircmaxell@gmail.com>
wrote:

> It's worth nothing that failing is the currently documented behavior:
> http://php.net/crypt
>
> Therefore, I'm suggesting we add an E_DEPRECATED error when we detect
> an invalid STD_DES salt but still execute the fallback:
> https://github.com/php/php-src/pull/989
>
> Then in a future version (7.1, 8, whatever) remove the fallback and
> keep the error along with returning a failure indication (*0).
>
> I'm open to tweaking the error message, and possibly changing to
> E_WARNING if people think it's worth it.
>
> Thoughts?
>

+1 for merging it as bug fix.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c2c72c3d776c050c7e0989--