Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80377
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEKnhAFvQpPxkoZKJ-2A-Fjm_ABqxPNMuJoqOsby3ELZgoyQ9g@mail.gmail.com>
References: <CAEKnhAFvQpPxkoZKJ-2A-Fjm_ABqxPNMuJoqOsby3ELZgoyQ9g@mail.gmail.com>
Date: Sun, 11 Jan 2015 19:07:19 +0000
Message-ID: <CAKxcST_e44EEXj7AuXm0xiXhNmfqjc6uCFRxD4bw6DFycNVy8A@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113a68fe53a0ff050c651934
Subject: Re: [PHP-DEV] [RFC] jsond
From: dragoonis@gmail.com (Paul Dragoonis)

--001a113a68fe53a0ff050c651934
Content-Type: text/plain; charset=UTF-8

On 11 Jan 2015 17:28, "Jakub Zelenka" <bukka@php.net> wrote:
>
> Hi,
>
> This rfc about replacing json with jsond is under discussion.
>
> https://wiki.php.net/rfc/jsond
>
> I have finally done some benchmarks. You can find a link in the RFC.
>
> It's been extensively tested for the last few months and there is just one
> BC that I'm aware of.
>
> The new parser accepts only float number that conforms to RFC 7159 . This
> is also not consistent between decoding float number that are and are not
> in the array/object ( there are two conversion rules). The following
> formats are rejected:
>
> 1. parsed at the top level: 07, 0xff, .1, -.1
> 2. parser by JSON_Parser: [1.], [1.e1]
>
> I feel that this was a bug in the new parser and we must conform to RFC
> 7159 !

I was just thinking about your jsond work just yesterday actually.

I feel if we need to make a minor BC break to get this in, then go with it
for PHP 7.

I do think that if it's possible for you to detect when users supply this
invalid float input that you would throw an informative exception to help
people with the transition over to PHP7.

What's the rest of the team's thoughts on this ?

>
> Cheers
>
> Jakub

--001a113a68fe53a0ff050c651934--