Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80349
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <D6650C2A-8150-4742-9B8F-238DC8A5703A@ajf.me>
References: <D6650C2A-8150-4742-9B8F-238DC8A5703A@ajf.me>
Date: Sun, 11 Jan 2015 11:26:19 +0800
Message-ID: <CABBJUpdsqeYTxwtgOt1h04nhwJjbz7aPBbugHdre4uc84azgKg@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] Fix octal parsing (finally)
From: laruence@php.net (Xinchen Hui)

Hey:

On Sun, Jan 11, 2015 at 6:37 AM, Andrea Faulds <ajf@ajf.me> wrote:
> Hey internals,
>
> A longstanding PHP bug is that invalid octal digits simply terminate the =
literal and are ignored, rather than generating a compile error. Thus, this=
 is valid:
>
>     $x =3D 0109; // same as 010, or 8
>
> I see no particular reason why this behaviour should be preserved. I=E2=
=80=99ve written a patch that would finally fix it, and avoid similar parsi=
ng issues in future (e.g. the resurgence of the hex addition bug), by error=
ing when strtol doesn=E2=80=99t reach the end of the literal.
>
> The pull request is here: https://github.com/php/php-src/pull/987
>
> I think this would be an acceptable BC break for PHP 7.
Agree,  IMO previously behavior actually is a bug...


thanks
>
> Thoughts?
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/