Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80343 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17034 invoked from network); 11 Jan 2015 02:26:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Jan 2015 02:26:56 -0000 Authentication-Results: pb1.pair.com header.from=jrbasso@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jrbasso@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.179 as permitted sender) X-PHP-List-Original-Sender: jrbasso@gmail.com X-Host-Fingerprint: 209.85.223.179 mail-ie0-f179.google.com Received: from [209.85.223.179] ([209.85.223.179:47003] helo=mail-ie0-f179.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 77/C9-48183-C6FD1B45 for ; Sat, 10 Jan 2015 21:26:52 -0500 Received: by mail-ie0-f179.google.com with SMTP id rp18so20719022iec.10 for ; Sat, 10 Jan 2015 18:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/28WgnGGHsj6dLCs/H5zHzUGvFQHanxd32/iKfT6W4Y=; b=QVcOjhl+Vp/bVMCBPW5NspiwFXtnDAKqiBkNKu2+8juDj78YMRksQaZDYTYo16l72U l8O2U+9gZxV2WNOlvRWw2kM1u6fDQX+cgueT/lTPeB8o5/Oz/4E+HuxCp8aTEJOoM+ng YbIEGWBE2N/Gmk5jQt5H7AjZmGtbg2J5gI9z+MZbiT9LwQ2b2g7Fc2drQmnBxCFiJoZn M19xBekef3jCAidmxLbj3F3n3yfxJ49bg+H2dByIiBrZQ1hoHsC+xdgRhCn88E++v9Yi p31lnAfG4RVnhqQywDiaNh6xTwEHWNd1HGH+0u9iyo1AS+R3YEgRX0wxrz2Os0B2RVt5 0hzg== MIME-Version: 1.0 X-Received: by 10.42.130.198 with SMTP id w6mr18647526ics.97.1420943208771; Sat, 10 Jan 2015 18:26:48 -0800 (PST) Received: by 10.64.91.65 with HTTP; Sat, 10 Jan 2015 18:26:48 -0800 (PST) In-Reply-To: References: <162491F3-F774-415C-A6B4-EB66D092C1A3@ajf.me> Date: Sat, 10 Jan 2015 21:26:48 -0500 Message-ID: To: Ferenc Kovacs Cc: PHP Internals Content-Type: multipart/alternative; boundary=90e6ba2121a5347b89050c571f34 Subject: Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode From: jrbasso@gmail.com (Juan Basso) --90e6ba2121a5347b89050c571f34 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I renamed the constant name on the RFC. Can I open the voting? On Wed, Jan 7, 2015 at 7:14 PM, Juan Basso wrote: > I really like the new name and the consistence with the rest of php. If n= o > one else has a complain about it I will update the RFC and open for votin= g, > right? > > Juan Basso > On Jan 5, 2015 7:31 AM, "Ferenc Kovacs" wrote: > >> >> >> On Mon, Jan 5, 2015 at 5:18 AM, Juan Basso wrote: >> >>> Hi, >>> >>> Everyone has any concern on the constant name as Andrea mentioned? Shou= ld >>> we keep or rename it? If this name is fine and there is no other concer= ns >>> probably in 3 days (when completes 2 weeks) this RFC can be moved to >>> voting, right? >>> >>> >>> Thanks, >>> Juan Basso >>> >> >> I prefer the originally proposed constant name >> (JSON_PRESERVE_FRACTIONAL_PART) over JSON_FLOAT_ADD_POINT_ZERO. >> I've did a quick check and we have a constant called >> FILTER_FLAG_ALLOW_FRACTION so maybe JSON_PRESERVE_FRACTION would be a bi= t >> simpler and consistent. >> But that would still imply that without this option we truncate >> (non-zero) fractional parts, so maybe something like >> JSON_PRESERVE_ZERO_FRACTION. >> I think PRESERVE is better than ADD because we aren't really adding >> something but making sure that it won't be lost through the json_encode. >> >> -- >> Ferenc Kov=C3=A1cs >> @Tyr43l - http://tyrael.hu >> > --90e6ba2121a5347b89050c571f34--