Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80324
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.214.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-b6KykyfUG8FmD0NkPzJPXGfJ+bOJWbGAWLrsB3ia8FA@mail.gmail.com>
References: <003e01d0290b$2387dd30$6a979790$@yahoo.fr>
	<007801d02ba0$659b9080$30d2b180$@tekwire.net>
	<CAF+90c-b6KykyfUG8FmD0NkPzJPXGfJ+bOJWbGAWLrsB3ia8FA@mail.gmail.com>
Date: Sat, 10 Jan 2015 18:01:10 +0200
Message-ID: <CAPhkiZy91xyB6VKt_WwO3_=RjhC6Fe4=QQs81OGAjGSgfgjObA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: francois@tekwire.net, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [BugFest] Feature request #38685: str_[i]replace(): Add
 support for (string needle, array replace)
From: narf@devilix.net (Andrey Andreev)

Hi,

On Sat, Jan 10, 2015 at 1:53 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> But if I see this (taken from the tests) as the search & replacement values...
>
> $search=array('[?]',array('(?)','d','e'),'a','R');
> $repl=array(
>     array('ap(?)z[?]',"b[?](?)v",null,37,"[?]n[?]"),
>     array('a',array('b',null)),
>     array('k(?)j[?]')
> );
>
> ... I have a pretty hard time figuring out what this is actually supposed
> to do. At this point str_replace is working on arbitrarily-nested arrays
> and also has four options to control its behavior.
>
> Imho this is just too much complexity for a relatively minor use case.

I have to agree here. Nested arrays are too much ... it should be
limited to single-dimention arrays.

Cheers,
Andrey.