Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80320
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <007801d02ba0$659b9080$30d2b180$@tekwire.net>
References: <003e01d0290b$2387dd30$6a979790$@yahoo.fr>
	<007801d02ba0$659b9080$30d2b180$@tekwire.net>
Date: Sat, 10 Jan 2015 12:53:38 +0100
Message-ID: <CAF+90c-b6KykyfUG8FmD0NkPzJPXGfJ+bOJWbGAWLrsB3ia8FA@mail.gmail.com>
To: francois@tekwire.net
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bf0c5387aec6c050c4aeca8
Subject: Re: [PHP-DEV] [BugFest] Feature request #38685: str_[i]replace(): Add
 support for (string needle, array replace)
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bf0c5387aec6c050c4aeca8
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 9, 2015 at 1:08 AM, Fran=C3=A7ois Laupretre <francois@tekwire.n=
et>
wrote:

> Hi,
>
> I just created the RFC :
>
> https://wiki.php.net/rfc/cyclic-replace
>
> I tried to include everything we agreed upon. Tell me if I missed
> something.
>
> Please note that the current PR does not implement the whole RFC. You may
> review the RFC while I update the code.
>
> Please also give me your opinion about implementing a similar feature in
> preg_replace() and preg_filter().
>

When submitting an RFC, please open a separate thread. Otherwise people who
do not follow every single discussion will not see it.

I'm against this RFC. Not because I don't like the implementation or
similar, I simply don't consider this functionality to be sufficiently
important to warrant both the additional internal complexity it adds and
the complexity it adds to our user-facing API.

str_replace is a simple function for string replacement. It has some (imho
also unnecessary) extra gimmicks to implicitly do a foreach() loop during
the replacement. This is still relatively simple API-wise. But if I see
this (taken from the tests) as the search & replacement values...

$search=3Darray('[?]',array('(?)','d','e'),'a','R');
$repl=3Darray(
    array('ap(?)z[?]',"b[?](?)v",null,37,"[?]n[?]"),
    array('a',array('b',null)),
    array('k(?)j[?]')
);

... I have a pretty hard time figuring out what this is actually supposed
to do. At this point str_replace is working on arbitrarily-nested arrays
and also has four options to control its behavior.

Imho this is just too much complexity for a relatively minor use case.

Nikita

--047d7bf0c5387aec6c050c4aeca8--