Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80242
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.220.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
Date: Wed, 7 Jan 2015 00:46:00 +0400
Message-ID: <CA+9eiLugveeEtTMApKeuiFKEnJ84LrGUu6U7-pSfnwO_gArL_g@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP Internals <internals@lists.php.net>, Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c2c67a0ae05b050c01e5b8
Subject: Re: Faster zend sorting implementation
From: dmitry@zend.com (Dmitry Stogov)

--001a11c2c67a0ae05b050c01e5b8
Content-Type: text/plain; charset=UTF-8

I think this break is acceptable
Of course, if the new sort implementation significantly improves
performance on some cases and doesn't show degradation on the others.

Thanks. Dmitry.
On Jan 5, 2015 9:08 PM, "Xinchen Hui" <laruence@php.net> wrote:

> Hey:
>
>      I was working on zend_qsort improvement. but I got a problem need
> to be disscussed with you fist..
>
>      as we know,  previously zend_qsort is not a stable sorting algo.
>
>      my draft patch (which already get 0.1% IRs reduce in wordpress)
> is kindof a stable sorting algo, you can find it here
> (https://github.com/laruence/php-src/compare/zend_sort)
>
>      so, there is a bc break, like for :
>
>      $array = array("o",  "O");
>      sort($array, SORT_STRING|SORT_FLAG_CASE);
>
>      var_dump($array);
>
>      previously implementation does the swap:
>
> array(2) {
>   [0]=>
>   string(1) "O"
>   [1]=>
>   string(1) "o"
> }
>
>      but new implementation doesn't not:
>
> array(2) {
>   [0]=>
>   string(1) "o"
>   [1]=>
>   string(1) "O"
> }
>
>     do you think such BC break is acceptable? or I still need a RFC? :<
>
> thanks
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--001a11c2c67a0ae05b050c01e5b8--