Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80226 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31092 invoked from network); 6 Jan 2015 08:06:11 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Jan 2015 08:06:11 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.41 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.192.41 mail-qg0-f41.google.com Received: from [209.85.192.41] ([209.85.192.41:63466] helo=mail-qg0-f41.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D2/C0-26786-C679BA45 for ; Tue, 06 Jan 2015 03:06:06 -0500 Received: by mail-qg0-f41.google.com with SMTP id e89so14626148qgf.0 for ; Tue, 06 Jan 2015 00:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bggh/M0D4bNMQJhcJyZZpNaKNIDBGT4YWwCdeAPcjo8=; b=wAEDXGN1/vDGPavFmrvuYBiwfS4aLRgTDu4cBagzSdGHTy3uJ4RT1SpvKbdmezcnkq /IKZQSMbYxYdWLKS1T0aBmzVq2Y6Xae2CI0+OKYQMm5qEZnZgzngaAeJPGG30K2EKdw+ LMFmCsqQdjRp7VhONyDcW67w2qAR96bif6zHBdt7GPYRJXvJDs2b8Ugp/2ip25uF5V9h ZlGIQIrssbQMM/Y26LQyXEy64LZhLZJajCr1I4183wt5PRkwAfUPUCwVaBn4tdnAlvGP iKfmDMXQ5KHsWkLWhoL7Q5LPuWpc8srwbU5UEZ9x/d3IqD5nQj1wRQ0XOJmcLSwr9kPe fUtQ== MIME-Version: 1.0 X-Received: by 10.140.43.52 with SMTP id d49mr145348813qga.94.1420531559631; Tue, 06 Jan 2015 00:05:59 -0800 (PST) Received: by 10.140.22.106 with HTTP; Tue, 6 Jan 2015 00:05:59 -0800 (PST) In-Reply-To: References: <54AB172E.6040901@gmail.com> Date: Tue, 6 Jan 2015 00:05:59 -0800 Message-ID: To: Jacob Bednarz Cc: Stanislav Malyshev , PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Cleaning up dangling whitespace From: pierre.php@gmail.com (Pierre Joye) On Mon, Jan 5, 2015 at 11:48 PM, Pierre Joye wrote: > On Mon, Jan 5, 2015 at 11:42 PM, Jacob Bednarz wrote: >> Hey >> >>> That reminds me something I was wondering, would it be possible to >>> have a kind of CS check on push? :) >> >> >> Yep - PHPCS[1] is quite good, easy to configure and has good editor >> integrations in the community. The automated code standards check can be >> achieved using git-hooks[2] which is already provided to us just by using >> git. One thing to keep in mind is that the PHP lint is only run on files you >> modified, not all within the repository. >> >> Stas, let me know if you would like a hand implementing/cleaning up this >> repository as I am happy wqto help. >> >> [1]: https://github.com/squizlabs/PHP_CodeSniffer >> [2]: http://git-scm.com/docs/githooks > > I did not PHPCS supports C. Or am I missing something? That's what I had in mind: https://gist.github.com/kblomqvist/bb59e781ce3e0006b644 rules to be adapted :) -- Pierre @pierrejoye | http://www.libgd.org