Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80223
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.175 as permitted sender)
Date: Tue, 6 Jan 2015 17:42:26 +1000 (AEST)
To: Pierre Joye <pierre.php@gmail.com>
cc: Stanislav Malyshev <smalyshev@gmail.com>, 
    PHP Internals <internals@lists.php.net>
In-Reply-To: <CAEZPtU7U32m8+JcGyRHPN4H4tTPFnLDChaXqCeUkFgL3Qu01=A@mail.gmail.com>
Message-ID: <alpine.OSX.2.11.1501061733020.52579@jacobs-macbook-pro.local>
References: <54AB172E.6040901@gmail.com> <CAEZPtU7U32m8+JcGyRHPN4H4tTPFnLDChaXqCeUkFgL3Qu01=A@mail.gmail.com>
User-Agent: Alpine 2.11 (OSX 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [PHP-DEV] Cleaning up dangling whitespace
From: jacob.bednarz@gmail.com (Jacob Bednarz)

Hey

> That reminds me something I was wondering, would it be possible to
> have a kind of CS check on push? :)

Yep - PHPCS[1] is quite good, easy to configure and has good editor 
integrations in the community. The automated code standards check can be 
achieved using git-hooks[2] which is already provided to us just by using 
git. One thing to keep in mind is that the PHP lint is only run on files 
you modified, not all within the repository.

Stas, let me know if you would like a hand implementing/cleaning up this 
repository as I am happy wqto help.

[1]: https://github.com/squizlabs/PHP_CodeSniffer
[2]: http://git-scm.com/docs/githooks

On Mon, 5 Jan 2015, Pierre Joye wrote:

> On Mon, Jan 5, 2015 at 2:58 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
>> Hi!
>>
>> The code in the PHP source repo has a lot of random dangling whitespace
>> at the end of lines, which looks sloppy and produces some weird effects
>> in diffs because some editors auto-clean it and some do not. I'd like to
>> clean it up (it's easy to do automatically) in master, but this produces
>> a big patch that may also create some conflicts with existing pull reqs
>> (easily resolved, but still).
>> So, I'd like to ask if there are any objections to such cleanup? If not,
>> then I'll do it, probably next weekend.
>
> Thanks for asking :)
>
> And go ahead, they should not be there in the 1st place, we have CS
> for a reason :)
>
> That reminds me something I was wondering, would it be possible to
> have a kind of CS check on push? :)
>
> Cheers,
> -- 
> Pierre
>
> @pierrejoye | http://www.libgd.org
>
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>