Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80220
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54AB172E.6040901@gmail.com>
References: <54AB172E.6040901@gmail.com>
Date: Mon, 5 Jan 2015 20:56:54 -0800
Message-ID: <CAEZPtU7U32m8+JcGyRHPN4H4tTPFnLDChaXqCeUkFgL3Qu01=A@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Cleaning up dangling whitespace
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Jan 5, 2015 at 2:58 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
> Hi!
>
> The code in the PHP source repo has a lot of random dangling whitespace
> at the end of lines, which looks sloppy and produces some weird effects
> in diffs because some editors auto-clean it and some do not. I'd like to
> clean it up (it's easy to do automatically) in master, but this produces
> a big patch that may also create some conflicts with existing pull reqs
> (easily resolved, but still).
> So, I'd like to ask if there are any objections to such cleanup? If not,
> then I'll do it, probably next weekend.

Thanks for asking :)

And go ahead, they should not be there in the 1st place, we have CS
for a reason :)

That reminds me something I was wondering, would it be possible to
have a kind of CS check on push? :)

Cheers,
-- 
Pierre

@pierrejoye | http://www.libgd.org