Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80216
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <54AAD22C.2010805@bastelstu.be>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
 <54AAD22C.2010805@bastelstu.be>
Date: Tue, 6 Jan 2015 10:39:57 +0800
Message-ID: <CABBJUpfzXJFgYuJdGA_pQb9zuF3T99=7D43Yna81SvxkCzGLow@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Faster zend sorting implementation
From: laruence@php.net (Xinchen Hui)

On Tue, Jan 6, 2015 at 2:04 AM, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote=
:
> On 05.01.2015 18:08, Xinchen Hui wrote:
>>     do you think such BC break is acceptable? or I still need a RFC? :<
>>
>
> Chiming in as a pure userland developer. The documentation already states=
:
>
>> Note: Like most PHP sorting functions, sort() uses an implementation
> of =C2=BB Quicksort. The pivot is chosen in the middle of the partition
> resulting in an optimal time for already sorted arrays. This is however
> an implementation detail you shouldn't rely on.
thanks, then I think no problem.

the reason why I asked is I found lots of test scripts starts to fail,
they all rely on the current non-stable sorting algo :<

thanks
>
> As the selection of the pivot element may also affect the order of equal
> elements and is explicitly defined as =E2=80=9Cone should not rely on it=
=E2=80=9D this
> change seems to be fine from my perspective.
>
> Tim



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/