Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80215
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <D42B9E13-D546-4245-BAD7-E434F42D1040@heroku.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
 <D42B9E13-D546-4245-BAD7-E434F42D1040@heroku.com>
Date: Tue, 6 Jan 2015 10:38:38 +0800
Message-ID: <CABBJUpfoYc6n2ncxLGP2URxeNApA9OtD+sZj8sEMYJ9UzRjcSA@mail.gmail.com>
To: David Zuelke <dz@heroku.com>
Cc: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Faster zend sorting implementation
From: laruence@php.net (Xinchen Hui)

On Tue, Jan 6, 2015 at 2:12 AM, David Zuelke <dz@heroku.com> wrote:
> This sounds reasonable, because given how the sort is *not* stable, there will be other cases (totally made up, but let's say ["a", "o", "O"]) where the swap does *not* happen. Consistency, and thus a stable sort, is better.
yeah, I also think in the same way..

>
> But you're saying your patch is "kind of a" stable sorting algo, so is it stable only sometimes, or did you mean to say "a kind of"?
>
actually, I use insert sort if elements is less than 17(<=16). so...

thanks
> David
>
>
>> On 05.01.2015, at 18:08, Xinchen Hui <laruence@php.net> wrote:
>>
>> Hey:
>>
>>     I was working on zend_qsort improvement. but I got a problem need
>> to be disscussed with you fist..
>>
>>     as we know,  previously zend_qsort is not a stable sorting algo.
>>
>>     my draft patch (which already get 0.1% IRs reduce in wordpress)
>> is kindof a stable sorting algo, you can find it here
>> (https://github.com/laruence/php-src/compare/zend_sort)
>>
>>     so, there is a bc break, like for :
>>
>>     $array = array("o",  "O");
>>     sort($array, SORT_STRING|SORT_FLAG_CASE);
>>
>>     var_dump($array);
>>
>>     previously implementation does the swap:
>>
>> array(2) {
>>  [0]=>
>>  string(1) "O"
>>  [1]=>
>>  string(1) "o"
>> }
>>
>>     but new implementation doesn't not:
>>
>> array(2) {
>>  [0]=>
>>  string(1) "o"
>>  [1]=>
>>  string(1) "O"
>> }
>>
>>    do you think such BC break is acceptable? or I still need a RFC? :<
>>
>> thanks
>> --
>> Xinchen Hui
>> @Laruence
>> http://www.laruence.com/
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/