Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80213
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.200 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
In-Reply-To: <54AB172E.6040901@gmail.com>
Date: Mon, 5 Jan 2015 23:25:07 +0000
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <FB86EA96-0F6A-43EA-BA38-06A8FB8629DF@ajf.me>
References: <54AB172E.6040901@gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Subject: Re: [PHP-DEV] Cleaning up dangling whitespace
From: ajf@ajf.me (Andrea Faulds)

Hey Stas,

> On 5 Jan 2015, at 22:58, Stanislav Malyshev <smalyshev@gmail.com> =
wrote:
>=20
> The code in the PHP source repo has a lot of random dangling =
whitespace
> at the end of lines, which looks sloppy and produces some weird =
effects
> in diffs because some editors auto-clean it and some do not. I'd like =
to
> clean it up (it's easy to do automatically) in master, but this =
produces
> a big patch that may also create some conflicts with existing pull =
reqs
> (easily resolved, but still).
> So, I'd like to ask if there are any objections to such cleanup? If =
not,
> then I'll do it, probably next weekend.

I expect you=E2=80=99ll cause me considerable pain when I have to merge =
that into the bigints branch. But it=E2=80=99s for the best. I=E2=80=99m =
actually pretty guilty of whitespace changes myself, so I probably =
deserve that pain.

No objections. :)

--
Andrea Faulds
http://ajf.me/