Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80212
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.214 cause and error)
Message-ID: <54AB1BC5.8020304@lsces.co.uk>
Date: Mon, 05 Jan 2015 23:18:29 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <54AB172E.6040901@gmail.com>
In-Reply-To: <54AB172E.6040901@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Cleaning up dangling whitespace
From: lester@lsces.co.uk (Lester Caine)

On 05/01/15 22:58, Stanislav Malyshev wrote:
> So, I'd like to ask if there are any objections to such cleanup? If not,
> then I'll do it, probably next weekend.

The bigger question is perhaps how they got added in the first place.
(And it's a bit like replacing all the tabs with spaces.) I've been
hitting patches that show a number of changes, but on closer inspection
it IS just a matter that a few odd lines have extra/different white
space. Having modified the merge process on my own repos so that
aesthetic changes are skipped keeps my own code tidier, but the master
copies on github still have the extras.

Basically - once the code has been swept can new patches be
automatically cleaned or will that still be a code review job?

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk