Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80209
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 87504 invoked from network); 5 Jan 2015 23:08:58 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Jan 2015 23:08:58 -0000
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.173 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 209.85.212.173 mail-wi0-f173.google.com  
Received: from [209.85.212.173] ([209.85.212.173:48288] helo=mail-wi0-f173.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 12/DC-21693-9891BA45 for <internals@lists.php.net>; Mon, 05 Jan 2015 18:08:58 -0500
Received: by mail-wi0-f173.google.com with SMTP id r20so4304211wiv.6
        for <internals@lists.php.net>; Mon, 05 Jan 2015 15:08:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=TTPbk3rOo8+i41gx40n/iezVioPozz/ghaQbGlH/nV8=;
        b=Rf/Jk378O/uJTl6zh+TvBF9Vw6SkTtR60ltcinnkID/1fVTLJsn6u2wLXj822YpXZL
         cASU8pSXQo+6LsVanz0lTLpjBjOOTehPThhk54TaDwPRpiFpUwercO1BIRXE4TSIolA1
         jkWC995HfcZCsF4E559HiedUZNmscseLRHFgO5lgyzx3F+DoY08N49oBvj6Js1CHCht7
         k5WyioYp0TKF3CVwc31I5dy+Yf7RUxGcSFAphLzt3Ak8TXztyebVQZ0TeFd9TFIwW17t
         EGG89TS5RgBB9j6S+cX0ELPeYYIciM0tBbVP3s2LWNCfCrTjd4m3Mo5SvJpp8ahBNYVM
         IjgQ==
MIME-Version: 1.0
X-Received: by 10.194.95.10 with SMTP id dg10mr185937777wjb.82.1420499333059;
 Mon, 05 Jan 2015 15:08:53 -0800 (PST)
Received: by 10.27.10.196 with HTTP; Mon, 5 Jan 2015 15:08:53 -0800 (PST)
In-Reply-To: <54AB172E.6040901@gmail.com>
References: <54AB172E.6040901@gmail.com>
Date: Tue, 6 Jan 2015 00:08:53 +0100
Message-ID: <CAF+90c89ES=C17FSbEwF+9zoudVpR+WE_TG7x6QmVqC--GnTuA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bdc8078269c79050befc64c
Subject: Re: [PHP-DEV] Cleaning up dangling whitespace
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bdc8078269c79050befc64c
Content-Type: text/plain; charset=UTF-8

On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> The code in the PHP source repo has a lot of random dangling whitespace
> at the end of lines, which looks sloppy and produces some weird effects
> in diffs because some editors auto-clean it and some do not. I'd like to
> clean it up (it's easy to do automatically) in master, but this produces
> a big patch that may also create some conflicts with existing pull reqs
> (easily resolved, but still).
> So, I'd like to ask if there are any objections to such cleanup? If not,
> then I'll do it, probably next weekend.
>

No objection to whitespace cleanup. iirc git even has options to ignore
whitespace changes on merge/rebase.

It would be nice to also add a pre-commit hook stripping trailing
whitespace, to avoid this happening again.

Nikita

--047d7bdc8078269c79050befc64c--