Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80203
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <14C3C30A-3B71-4DB7-B406-91429A7B05B6@ajf.me>
References: <003e01d0290b$2387dd30$6a979790$@yahoo.fr>
	<FFF8F5D3-A82A-4A85-8728-79332E274CA1@ajf.me>
	<CAH-PCH5jLdpXpm371SbiiQBE6NP8exGKgDhFyZ8_4X3ZQwv-pQ@mail.gmail.com>
	<54AAF3DE.2050508@gmail.com>
	<14C3C30A-3B71-4DB7-B406-91429A7B05B6@ajf.me>
Date: Mon, 5 Jan 2015 23:10:25 +0100
Message-ID: <CAH-PCH74kvgOvKVfrsCXzmzYW2bv8bD+SKngt8hR9ZDYFtr9sg@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, nf.laupretre@yahoo.fr, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bd9058e14f1c7050beef57c
Subject: Re: [PHP-DEV] [BugFest] Feature request #38685: str_[i]replace(): Add
 support for (string needle, array replace)
From: tyra3l@gmail.com (Ferenc Kovacs)

--047d7bd9058e14f1c7050beef57c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 5, 2015 at 9:30 PM, Andrea Faulds <ajf@ajf.me> wrote:

>
> > On 5 Jan 2015, at 20:28, Stanislav Malyshev <smalyshev@gmail.com> wrote=
:
> >
> > Hi!
> >
> >> usually each BC break would warrant an RFC and a vote, but I'm not sur=
e
> >> many people would use str_replace("foo", array("bar"), $subject); and
> >> expect the implicit array to string conversion of array("bar") =3D>
> "Array"
> >> which also emits a notice.
> >> let's see what others think.
> >
> > I wouldn't consider this a BC break. Anybody who relies on implicit
> > array->string conversion has a bug anyway, and we allow that implicit
> > conversion to survive only for legacy reasons, but I don't think it
> > should drag behind itself the promise we'd never support array paramete=
r
> > where there was only string before. In summary, I'd say no BC break her=
e.
>
> To add to what Stas says: ZPP doesn=E2=80=99t allow array->string anyway,=
 this is
> just a quirk in str_replace=E2=80=99s handling of its =E2=80=98z=E2=80=99=
 parameter. So users
> wouldn=E2=80=99t expect it to work anyway, right?
>

users don't know much about how zend parameter parsing works in general,
and both $search and $replace is documented as mixed plus the only
reference about this usage in the documentation is the "The converse would
not make sense, though. " sentence which can be easy to miss.
So while I agree that the current working doesn't make much sense, I don't
think that it is that obvious that this shouldn't behave as it does atm.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--047d7bd9058e14f1c7050beef57c--