Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80194
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain bastelstu.be designates 78.46.88.104 as permitted sender)
Message-ID: <54AAD4C0.2090304@bastelstu.be>
Date: Mon, 05 Jan 2015 19:15:28 +0100
MIME-Version: 1.0
To: internals@lists.php.net
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
In-Reply-To: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Faster zend sorting implementation
From: timwolla@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Sorry if someone receives this reply twice. I sent it by a different
alias by accident and apparently the sender confirmation does not work
properly.

On 05.01.2015 18:08, Xinchen Hui wrote:
>     do you think such BC break is acceptable? or I still need a RFC?
>

Chiming in as a pure userland developer. The documentation already states:

> Note: Like most PHP sorting functions, sort() uses an implementation
of » Quicksort. The pivot is chosen in the middle of the partition
resulting in an optimal time for already sorted arrays. This is however
an implementation detail you shouldn't rely on.

As the selection of the pivot element may also affect the order of equal
elements and is explicitly defined as “one should not rely on it” this
change seems to be fine from my perspective.

Tim