Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80191
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <FFF8F5D3-A82A-4A85-8728-79332E274CA1@ajf.me>
References: <003e01d0290b$2387dd30$6a979790$@yahoo.fr>
	<FFF8F5D3-A82A-4A85-8728-79332E274CA1@ajf.me>
Date: Mon, 5 Jan 2015 19:06:38 +0100
Message-ID: <CAH-PCH5jLdpXpm371SbiiQBE6NP8exGKgDhFyZ8_4X3ZQwv-pQ@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: nf.laupretre@yahoo.fr, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d044267fe3d115c050beb8db3
Subject: Re: [PHP-DEV] [BugFest] Feature request #38685: str_[i]replace(): Add
 support for (string needle, array replace)
From: tyra3l@gmail.com (Ferenc Kovacs)

--f46d044267fe3d115c050beb8db3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 5, 2015 at 6:20 PM, Andrea Faulds <ajf@ajf.me> wrote:

> Hey Fran=C3=A7ois,
>
> > On 5 Jan 2015, at 17:15, F & N Laupretre <nf.laupretre@yahoo.fr> wrote:
> >
> > I just created a PR for a feature request lying around since 2006 :
> >
> > https://github.com/php/php-src/pull/980
> >
> > It adds support in str_replace() and str_ireplace() for the combination
> of
> > (string needle, array replace). In this case, each occurrence of the
> needle
> > is replaced with an element f the 'replace' array, looping if
> count(replace)
> > is lower than count(needles) in subject. It is interesting for cyclic
> > replacements (alternating line colors, for instance). The PR includes t=
he
> > needed tests.
>
> This would have been really useful for me quite recently, I was
> disappointed to see it doesn=E2=80=99t already work. Please go ahead with=
 this!
>
> Thanks.
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
usually each BC break would warrant an RFC and a vote, but I'm not sure
many people would use str_replace("foo", array("bar"), $subject); and
expect the implicit array to string conversion of array("bar") =3D> "Array"
which also emits a notice.
let's see what others think.


--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--f46d044267fe3d115c050beb8db3--