Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80190
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <2F0DAC60-C06B-4C53-BE70-41B260C8093C@gmail.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
	<CABBJUpcSLSQ=etZ7NYKcOR+Kcvkga=Op-BR_KcqOE-5S3H70og@mail.gmail.com>
	<CAMUwpuQodU3r54bna_XJoR8FN5KXTvOT1UMdBvTgFnxZK3Appw@mail.gmail.com>
	<2F0DAC60-C06B-4C53-BE70-41B260C8093C@gmail.com>
Date: Mon, 5 Jan 2015 12:59:46 -0500
Message-ID: <CAA8DMBsDys+TYGq=amXB8FTTPyLptNXKCGO5tjGqA=0r9TxzQg@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: Faster zend sorting implementation
From: figureonecpr@gmail.com (Sanford Whiteman)

Sounds more like a bugfix to me and def'ly an acceptable BC break in
either case. The behavior isn't specified and if anything I would
assume there _wouldn't_ be a swap with SORT_FLAG_CASE on. Interesting
though that many sorting examples (across languages) sidestep this
clearly common case.

-- S.

On Mon, Jan 5, 2015 at 12:36 PM, Xinchen Hui <laruence@gmail.com> wrote:
> Hey=EF=BC=9A
>
>> On Jan 6, 2015, at 1:27 AM, Julien Pauli <jpauli@php.net> wrote:
>>
>>> On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui <laruence@php.net> wrote:
>>> On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui <laruence@php.net> wrote:
>>> > Hey:
>>> >
>>> >      I was working on zend_qsort improvement. but I got a problem nee=
d
>>> > to be disscussed with you fist..
>>> first
>>> >
>>> >      as we know,  previously zend_qsort is not a stable sorting algo.
>>> >
>>> >      my draft patch (which already get 0.1% IRs reduce in wordpress)
>>> > is kindof a stable sorting algo, you can find it here
>>> > (https://github.com/laruence/php-src/compare/zend_sort)
>>> >
>>> >      so, there is a bc break, like for :
>>> >
>>> >      $array =3D array("o",  "O");
>>> >      sort($array, SORT_STRING|SORT_FLAG_CASE);
>>> >
>>> >      var_dump($array);
>>> >
>>> >      previously implementation does the swap:
>>> >
>>> > array(2) {
>>> >   [0]=3D>
>>> >   string(1) "O"
>>> >   [1]=3D>
>>> >   string(1) "o"
>>> > }
>>> >
>>> >      but new implementation doesn't not:
>>> does not
>>> >
>>> > array(2) {
>>> >   [0]=3D>
>>> >   string(1) "o"
>>> >   [1]=3D>
>>> >   string(1) "O"
>>> > }
>>
>> Hum, I dont think such a BC is acceptable.
>>
> I am not sure if you get the problem?
>
> "O" and "o" are equal is that script
>
> The flags means using case-insensitive string sorting mean
>
> Thanks
>> There are tons of userland code out there relying on alpha case sorting =
that could get impacted....
>> IMO :-)
>>
>> Q: why extract the swap function from the qsort algo ? Is there an inter=
est of replacing it at runtime ?
>>
>>
>> Julien.P