Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80189
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.45 as permitted sender)
Content-Type: multipart/alternative;
	boundary=Apple-Mail-6B484B0D-F26C-4540-870F-E779F5835317
Mime-Version: 1.0 (1.0)
In-Reply-To: <CAMUwpuQodU3r54bna_XJoR8FN5KXTvOT1UMdBvTgFnxZK3Appw@mail.gmail.com>
Date: Tue, 6 Jan 2015 01:36:03 +0800
Cc: Xinchen Hui <laruence@php.net>,
 PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>,
 Nikita Popov <nikita.ppv@gmail.com>
Content-Transfer-Encoding: 7bit
Message-ID: <2F0DAC60-C06B-4C53-BE70-41B260C8093C@gmail.com>
References: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com> <CABBJUpcSLSQ=etZ7NYKcOR+Kcvkga=Op-BR_KcqOE-5S3H70og@mail.gmail.com> <CAMUwpuQodU3r54bna_XJoR8FN5KXTvOT1UMdBvTgFnxZK3Appw@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Subject: Re: [PHP-DEV] Re: Faster zend sorting implementation
From: laruence@gmail.com (Xinchen Hui)

--Apple-Mail-6B484B0D-F26C-4540-870F-E779F5835317
Content-Type: text/plain;
	charset=gb2312
Content-Transfer-Encoding: quoted-printable

Hey=A3=BA

> On Jan 6, 2015, at 1:27 AM, Julien Pauli <jpauli@php.net> wrote:
>=20
>> On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui <laruence@php.net> wrote:
>> On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui <laruence@php.net> wrote:
>> > Hey:
>> >
>> >      I was working on zend_qsort improvement. but I got a problem need
>> > to be disscussed with you fist..
>> first
>> >
>> >      as we know,  previously zend_qsort is not a stable sorting algo.
>> >
>> >      my draft patch (which already get 0.1% IRs reduce in wordpress)
>> > is kindof a stable sorting algo, you can find it here
>> > (https://github.com/laruence/php-src/compare/zend_sort)
>> >
>> >      so, there is a bc break, like for :
>> >
>> >      $array =3D array("o",  "O");
>> >      sort($array, SORT_STRING|SORT_FLAG_CASE);
>> >
>> >      var_dump($array);
>> >
>> >      previously implementation does the swap:
>> >
>> > array(2) {
>> >   [0]=3D>
>> >   string(1) "O"
>> >   [1]=3D>
>> >   string(1) "o"
>> > }
>> >
>> >      but new implementation doesn't not:
>> does not
>> >
>> > array(2) {
>> >   [0]=3D>
>> >   string(1) "o"
>> >   [1]=3D>
>> >   string(1) "O"
>> > }
>=20
> Hum, I dont think such a BC is acceptable.
>=20
I am not sure if you get the problem?

"O" and "o" are equal is that script

The flags means using case-insensitive string sorting mean

Thanks
> There are tons of userland code out there relying on alpha case sorting th=
at could get impacted....
> IMO :-)
>=20
> Q: why extract the swap function from the qsort algo ? Is there an interes=
t of replacing it at runtime ?
>=20
>=20
> Julien.P

--Apple-Mail-6B484B0D-F26C-4540-870F-E779F5835317--