Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80183
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.44 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <alpine.DEB.2.11.1501041321050.4080@whisky.home.derickrethans.nl>
References: <CAESVnVrA_Z3cS2yYy7WStDaXib6PLnHUD6BXQSL3VL6pB6TUvA@mail.gmail.com>
 <EB09BC7C-E3F9-44E9-8A5A-EE6DD0CA689E@ajf.me> <3CB15CBB-8912-48E0-A3FF-6B0436F32616@golemon.com>
 <alpine.DEB.2.11.1501041321050.4080@whisky.home.derickrethans.nl>
Date: Mon, 5 Jan 2015 18:08:29 +0100
Message-ID: <CAMUwpuRnDZ9aNi9ur8wjZAj_62ZeKm2TenV9ivGdMqaqzXSHHw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Sara Golemon <php@golemon.com>, Andrea Faulds <ajf@ajf.me>, Sara Golemon <pollita@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec53f33d7af768e050beabf4a
Subject: Re: [PHP-DEV] ZEND_ENGINE_2 define
From: jpauli@php.net (Julien Pauli)

--bcaec53f33d7af768e050beabf4a
Content-Type: text/plain; charset=UTF-8

On Sun, Jan 4, 2015 at 2:21 PM, Derick Rethans <derick@php.net> wrote:

> On Fri, 2 Jan 2015, Sara Golemon wrote:
>
> >
> > > It was deliberate, I did it. The reason for getting rid of it was
> because it makes checking ZE2 simpler, actually. I didn't want to have to
> do #if defined(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3).
> > >
> > So instead you have to do:
> > #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
> >
> > But cool, kind of arbitrary either way, so it's all good.
>
> I'm rather more of a fan to actually do:
>
> #if PHP_VERSION_ID >= 70000 instead anyway....
>

Yeah, same to me.
I'm used to using something like this :

https://github.com/jpauli/symfony/blob/eventdispatcher_ext/src/Symfony/Component/EventDispatcher/Resources/ext/sensiolabs_php_compat.h#L23


Julien

--bcaec53f33d7af768e050beabf4a--