Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80182
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.50 as permitted sender)
MIME-Version: 1.0
Date: Tue, 6 Jan 2015 01:08:35 +0800
Message-ID: <CABBJUpcxizh-SMQNOYX4Ejr6sOnoGw-78Nz28Db4JKWwNd9XCw@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>, Dmitry Stogov <dmitry@zend.com>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Faster zend sorting implementation
From: laruence@php.net (Xinchen Hui)

Hey:

     I was working on zend_qsort improvement. but I got a problem need
to be disscussed with you fist..

     as we know,  previously zend_qsort is not a stable sorting algo.

     my draft patch (which already get 0.1% IRs reduce in wordpress)
is kindof a stable sorting algo, you can find it here
(https://github.com/laruence/php-src/compare/zend_sort)

     so, there is a bc break, like for :

     $array = array("o",  "O");
     sort($array, SORT_STRING|SORT_FLAG_CASE);

     var_dump($array);

     previously implementation does the swap:

array(2) {
  [0]=>
  string(1) "O"
  [1]=>
  string(1) "o"
}

     but new implementation doesn't not:

array(2) {
  [0]=>
  string(1) "o"
  [1]=>
  string(1) "O"
}

    do you think such BC break is acceptable? or I still need a RFC? :<

thanks
-- 
Xinchen Hui
@Laruence
http://www.laruence.com/