Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80170
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+sv8zD-P-CXaC0DB1aq8CdL-K5_Czp6TBmnPW7J4ir-H-Gh+w@mail.gmail.com>
References: <CA+sv8zBTACqMK9ndFb1vHTWe5h1r50dh+Og93_OcwdC1vdcDQQ@mail.gmail.com>
	<162491F3-F774-415C-A6B4-EB66D092C1A3@ajf.me>
	<CA+sv8zCvOwsdZQBZc0ANob8JeZ2tKpe-=xNo2Bcri1hfUaDq4A@mail.gmail.com>
	<CA+sv8zD-P-CXaC0DB1aq8CdL-K5_Czp6TBmnPW7J4ir-H-Gh+w@mail.gmail.com>
Date: Mon, 5 Jan 2015 10:31:36 +0100
Message-ID: <CAH-PCH4inc1mRojDO24R43LTHksKeUnAkRDJ+0FJcoK+FmgP4w@mail.gmail.com>
To: Juan Basso <jrbasso@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bd9058e5c4dc2050be45b3f
Subject: Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode
From: tyra3l@gmail.com (Ferenc Kovacs)

--047d7bd9058e5c4dc2050be45b3f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 5, 2015 at 5:18 AM, Juan Basso <jrbasso@gmail.com> wrote:

> Hi,
>
> Everyone has any concern on the constant name as Andrea mentioned? Should
> we keep or rename it? If this name is fine and there is no other concerns
> probably in 3 days (when completes 2 weeks) this RFC can be moved to
> voting, right?
>
>
> Thanks,
> Juan Basso
>

I prefer the originally proposed constant name
(JSON_PRESERVE_FRACTIONAL_PART) over JSON_FLOAT_ADD_POINT_ZERO.
I've did a quick check and we have a constant called
FILTER_FLAG_ALLOW_FRACTION so maybe JSON_PRESERVE_FRACTION would be a bit
simpler and consistent.
But that would still imply that without this option we truncate (non-zero)
fractional parts, so maybe something like JSON_PRESERVE_ZERO_FRACTION.
I think PRESERVE is better than ADD because we aren't really adding
something but making sure that it won't be lost through the json_encode.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--047d7bd9058e5c4dc2050be45b3f--