Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80169
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+sv8zCvOwsdZQBZc0ANob8JeZ2tKpe-=xNo2Bcri1hfUaDq4A@mail.gmail.com>
References: <CA+sv8zBTACqMK9ndFb1vHTWe5h1r50dh+Og93_OcwdC1vdcDQQ@mail.gmail.com>
	<162491F3-F774-415C-A6B4-EB66D092C1A3@ajf.me>
	<CA+sv8zCvOwsdZQBZc0ANob8JeZ2tKpe-=xNo2Bcri1hfUaDq4A@mail.gmail.com>
Date: Mon, 5 Jan 2015 02:18:28 -0200
Message-ID: <CA+sv8zD-P-CXaC0DB1aq8CdL-K5_Czp6TBmnPW7J4ir-H-Gh+w@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c11e0681915d050bdffb47
Subject: Re: [PHP-DEV] [RFC] Preserve Fractional Part in JSON encode
From: jrbasso@gmail.com (Juan Basso)

--001a11c11e0681915d050bdffb47
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

Everyone has any concern on the constant name as Andrea mentioned? Should
we keep or rename it? If this name is fine and there is no other concerns
probably in 3 days (when completes 2 weeks) this RFC can be moved to
voting, right?


Thanks,
Juan Basso

On Thu, Dec 25, 2014 at 9:17 PM, Juan Basso <jrbasso@gmail.com> wrote:

> Andrea,
>
> I am not a specialist in float numbers, but I think integral float number=
s
> have a fractional part with value 0.
>
> JSON_FLOAT_ADD_POINT_ZERO can be confuse for regular floats with non-zero
> as fractional part. Seems you are going to add a point zero in a regular
> float with point something.
>
> Anyway, I am open to rename the constant to make it clear for everyone. I
> just can't find a better name than that. By the way, this name was propos=
ed
> by Kevin Israel (plstand) on the PR.
>
> On Thu, Dec 25, 2014 at 9:01 PM, Andrea Faulds <ajf@ajf.me> wrote:
>
>>
>> > On 25 Dec 2014, at 19:32, Juan Basso <jrbasso@gmail.com> wrote:
>> >
>> > The RFC can be found here:
>> > https://wiki.php.net/rfc/json_preserve_fractional_part
>>
>> Hey Juan,
>>
>> A further thought: is =E2=80=9CPreserve Fractional Part=E2=80=9D the bes=
t name? Integral
>> floats like float(12) don=E2=80=99t have any fractional part, and beside=
s, the name
>> doesn=E2=80=99t tell you what it does IMO. Perhaps something like
>> JSON_FLOAT_ADD_POINT_ZERO? It=E2=80=99s more literal and, I think, more =
obvious.
>>
>> Thanks.
>>
>> --
>> Andrea Faulds
>> http://ajf.me/
>>
>>
>>
>>
>>
>

--001a11c11e0681915d050bdffb47--