Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80158
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.207 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
In-Reply-To: <CAOjCV8wkeTgqyp6s90uyV5R1P1tBMgR=gb-hv3jxmVx2hh5WpQ@mail.gmail.com>
Date: Sun, 4 Jan 2015 19:11:00 +0000
Cc: Derick Rethans <derick@php.net>,
 Stanislav Malyshev <smalyshev@gmail.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <53DCFD59-4980-4FDE-9387-AF8D0E7A6E71@ajf.me>
References: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me> <54A466CB.9020400@gmail.com> <alpine.DEB.2.11.1501041727320.4080@whisky.home.derickrethans.nl> <CAOjCV8wkeTgqyp6s90uyV5R1P1tBMgR=gb-hv3jxmVx2hh5WpQ@mail.gmail.com>
To: "Sebastian B.-Hagensen" <sbj.ml.read@gmail.com>
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints
From: ajf@ajf.me (Andrea Faulds)

Hey Sebastian,

> On 4 Jan 2015, at 19:02, Sebastian B.-Hagensen <sbj.ml.read@gmail.com> =
wrote:
>=20
> It might add some value to forbid importing of unaliased type named
> classes via use, so that no ambiguous type annotation exists.
> Example:
>=20
> use My\Lib\string as UserString; // fine, no error
> use My\Lib\int; // Compile error: Forbidden to import scalar type. Use
> `as` to create an alias

That=E2=80=99s something that was actually on my todo list. No point in =
forbidding class names if you can get around it with `use`.

Once I do this in the patch I=E2=80=99ll update the RFC to say as much.

> Most libraries should be able to resolve such issues in a minor
> release to stay compatible with PHP 7. If a user doesn't use PHP 7 he
> won't be affected as the old import still works and the name of the
> class (if namespaced) hasn't changed, if he switches to PHP7 the
> updates can probably be automated.

Yes, this is possible. You could just rename the class to something =
that=E2=80=99s OK in both PHP 5 and 7 (IntClass, e.g.), then add a =
conditional class_alias() for PHP 5.

Actually, I=E2=80=99d need to update class_alias() as well. Hmm. Maybe I =
should make some sort of internal is_class_name_permitted() function.

> Namespaced classes can still be named whatever they want as the
> following(typehint an alias of the own class, using FQN) is already
> valid and the signature of the method would not change(no major
> release of a library required).:
>=20
> namspace abc;
> use abc\int as MyInt;
>=20
> class int { function a(MyInt $a, \abc\int $b) ;}

I don=E2=80=99t like the idea of allowing these within namespaces, =
because relative uses would still be broken. Better to just force people =
to fix their class names.

Thanks.
--
Andrea Faulds
http://ajf.me/