Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80150 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95831 invoked from network); 4 Jan 2015 13:43:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Jan 2015 13:43:40 -0000 Authentication-Results: pb1.pair.com header.from=francois@tekwire.net; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=francois@tekwire.net; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain tekwire.net does not designate 212.27.42.2 as permitted sender) X-PHP-List-Original-Sender: francois@tekwire.net X-Host-Fingerprint: 212.27.42.2 smtp2-g21.free.fr Received: from [212.27.42.2] ([212.27.42.2:38733] helo=smtp2-g21.free.fr) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BA/B2-15455-88349A45 for ; Sun, 04 Jan 2015 08:43:39 -0500 Received: from moorea (unknown [82.240.16.115]) by smtp2-g21.free.fr (Postfix) with ESMTP id 286DC4B010F; Sun, 4 Jan 2015 14:41:46 +0100 (CET) Reply-To: To: "'Pierre Joye'" Cc: "'PHP internals'" References: <003901d027be$d1837ff0$748a7fd0$@tekwire.net> In-Reply-To: Date: Sun, 4 Jan 2015 14:43:32 +0100 Message-ID: <003401d02824$6e7af530$4b70df90$@tekwire.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJnHRlI5B6zrZ1DNvutxO6zqwMUmAHv7fH2m3KH8KA= Content-Language: fr X-Antivirus: avast! (VPS 150104-0, 04/01/2015), Outbound message X-Antivirus-Status: Clean Subject: RE: [PHP-DEV] [RFC] Add is_cacheable() stream-wrapper operation From: francois@tekwire.net (=?UTF-8?Q?Fran=C3=A7ois_Laupretre?=) > De : Pierre Joye [mailto:pierre.php@gmail.com] > Could you add tests please? A must before going any further :) Three tests are included in the patch : one to check that phar uris are = cacheable, one to check that plain files and 'file:' uris are cacheable, = one to check that 'http' and 'https' uris are not cacheable. An additional test should be added in the opcache tests dir to check = that opcache is caching plain files, phar uris, but not other protocols. = It is in my todo list, but I wanted your comments first, as it is more = complex to implement. > Please add the changes to UPGRADING.INTERNALS and UPGRADING as well. Done Regards Fran=C3=A7ois