Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80149
Return-Path: <derick@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 92386 invoked from network); 4 Jan 2015 13:21:40 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 4 Jan 2015 13:21:40 -0000
Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
X-PHP-List-Original-Sender: derick@php.net
X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6
Received: from [82.113.146.227] ([82.113.146.227:60277] helo=xdebug.org)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 0D/12-15455-26E39A45 for <internals@lists.php.net>; Sun, 04 Jan 2015 08:21:39 -0500
Received: from localhost (localhost [IPv6:::1])
	by xdebug.org (Postfix) with ESMTPS id 1A54E10C008;
	Sun,  4 Jan 2015 13:21:34 +0000 (GMT)
Date: Sun, 4 Jan 2015 13:21:34 +0000 (GMT)
X-X-Sender: derick@whisky.home.derickrethans.nl
To: Sara Golemon <php@golemon.com>
cc: Andrea Faulds <ajf@ajf.me>, Sara Golemon <pollita@php.net>, 
    PHP internals <internals@lists.php.net>
In-Reply-To: <3CB15CBB-8912-48E0-A3FF-6B0436F32616@golemon.com>
Message-ID: <alpine.DEB.2.11.1501041321050.4080@whisky.home.derickrethans.nl>
References: <CAESVnVrA_Z3cS2yYy7WStDaXib6PLnHUD6BXQSL3VL6pB6TUvA@mail.gmail.com> <EB09BC7C-E3F9-44E9-8A5A-EE6DD0CA689E@ajf.me> <3CB15CBB-8912-48E0-A3FF-6B0436F32616@golemon.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] ZEND_ENGINE_2 define
From: derick@php.net (Derick Rethans)

On Fri, 2 Jan 2015, Sara Golemon wrote:

> 
> > It was deliberate, I did it. The reason for getting rid of it was because it makes checking ZE2 simpler, actually. I didn't want to have to do #if defined(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3).
> > 
> So instead you have to do:
> #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
> 
> But cool, kind of arbitrary either way, so it's all good.

I'm rather more of a fan to actually do:

#if PHP_VERSION_ID >= 70000 instead anyway....

cheers,
Derick