Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80144
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain tekwire.net does not designate 212.27.42.2 as permitted sender)
Reply-To: <francois@tekwire.net>
To: "'Benjamin Eberlei'" <kontakt@beberlei.de>,
	"'PHP Internals'" <internals@lists.php.net>
References: <CAEPJdu=2oWiSCQOTkO1g5QDs4NrJwd5H14Jks17qrNu7-eQNVg@mail.gmail.com>
In-Reply-To: <CAEPJdu=2oWiSCQOTkO1g5QDs4NrJwd5H14Jks17qrNu7-eQNVg@mail.gmail.com>
Date: Sun, 4 Jan 2015 13:36:52 +0100
Message-ID: <002d01d0281b$1e775730$5b660590$@tekwire.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKBrOMj1TuM8+kkOgWpn3PeY833k5tM1pvw
Content-Language: fr
Subject: RE: [PHP-DEV] [RFC] Extension Prepend Files
From: francois@tekwire.net (=?UTF-8?Q?Fran=C3=A7ois_Laupretre?=)

> De : Benjamin Eberlei [mailto:kontakt@beberlei.de]
> I want to open discussion on my RFC to strengthen the ability of =
extensions
> to provide functionality to developers in both C **and** PHP code.
>=20
> For this extensions can add PHP files to a list of "prepend files" =
that are
> part of every request execution exactly the same way the INI
> auto_prepend_file functionality works:
>=20
> https://wiki.php.net/rfc/extension_prepend_files
>=20
> I propose implementation details in the RFC, but they are completely =
up to
> discussion. I am even sure there is probably a better way than what I
> proposed, because I am not familiar with the code.

Can you please develop the API changes in your RFC ? You're talking =
about changes in zend_execute_scripts(), a new zend_execute_script() =
function (but the name in the prototype is wrong), then =
php_execute_scripts()...

Where are the file handles coming from ? Does it mean that the files to =
prepend will be kept open ?

Do you register paths to prepend, or will the scripts be loaded in =
memory during MINIT ?

How will these files be cached by opcode caches (mandatory for such a =
feature) ?

And, finally, how can an extension determine where a given PHP script it =
requires has been installed ? It makes sense in php.ini because it is =
under control of the final user. But an extension is just a C library, =
installed anywhere or bundled in the PHP executable. Would it compute =
the script paths from PHP installation paths ?

Actually, I don't see how it would work with PHP scripts which would =
remain separate from the extension code. What I would imagine for such a =
feature, would be PHP code embedded in the extension as a memory buffer, =
registered during MINIT, and then executed at each RINIT. This would =
probably require a stream wrapper because the opcode cache would require =
paths for this code. We can also concatenate the scripts but we still =
need a virtual path. The stream wrapper would just be simpler to =
implement.

Regards

Fran=C3=A7ois