Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80118
Return-Path: <php@golemon.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 43828 invoked from network); 3 Jan 2015 06:44:48 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 3 Jan 2015 06:44:48 -0000
Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail
Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.217.179 as permitted sender)
X-PHP-List-Original-Sender: php@golemon.com
X-Host-Fingerprint: 209.85.217.179 mail-lb0-f179.google.com  
Received: from [209.85.217.179] ([209.85.217.179:42904] helo=mail-lb0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 79/91-32964-EDF87A45 for <internals@lists.php.net>; Sat, 03 Jan 2015 01:44:47 -0500
Received: by mail-lb0-f179.google.com with SMTP id z11so15618745lbi.38
        for <internals@lists.php.net>; Fri, 02 Jan 2015 22:44:43 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:sender:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type;
        bh=xwdB1FA7MQBz468XnO8gtKcXxcgwfZ1JhPR3pWKA5v0=;
        b=ZYbbUqf3uJnZVP2oMYKQE/l80pAmsJ73ZiI+J6Q4mA4LUzMB5C4NhaSznqYrz2DY9e
         8ua9mRrrdlRYn7bBpq3coOKsuxGMn4uupV9SANRM3OtxMLxxeCtSBbIn4VZO9JzkTwe2
         LgMj8cv/bF3+EMOBiohrR5RSO+Zi8blmcWjTJdsrUKt4/H6GxODxhntmEC1wz1JpdugF
         kMPpSDibr3uBjtdG0e9isp+e3VYzF6xHqlQkWYCWTrmKTpiQbo9bCh+4lxOkR7HhHMpX
         riHTWp22TDF8FTbeOqZ6q1GkLCkNuE0H1LjONQq6mnQhotPITiWKFAfkEKB0IXGdk/mh
         5yIA==
X-Gm-Message-State: ALoCoQmGwZeRZ8uVzs39DiQ6XBLOSC7QgqVzPEuWt1Q94Hpu3joZc52ENQAMothX3Xdstdt2ifVa
MIME-Version: 1.0
X-Received: by 10.112.183.197 with SMTP id eo5mr79892451lbc.81.1420267483856;
 Fri, 02 Jan 2015 22:44:43 -0800 (PST)
Sender: php@golemon.com
Received: by 10.112.171.97 with HTTP; Fri, 2 Jan 2015 22:44:43 -0800 (PST)
X-Originating-IP: [69.63.185.56]
In-Reply-To: <CAJW__o1iSYo8x9bzQWQ9Ru4RM=ExEEabgbZKOJGudoweibeecw@mail.gmail.com>
References: <CAESVnVrA_Z3cS2yYy7WStDaXib6PLnHUD6BXQSL3VL6pB6TUvA@mail.gmail.com>
	<EB09BC7C-E3F9-44E9-8A5A-EE6DD0CA689E@ajf.me>
	<3CB15CBB-8912-48E0-A3FF-6B0436F32616@golemon.com>
	<CAJW__o1iSYo8x9bzQWQ9Ru4RM=ExEEabgbZKOJGudoweibeecw@mail.gmail.com>
Date: Fri, 2 Jan 2015 22:44:43 -0800
X-Google-Sender-Auth: naANhj3pIm2veszc16W6LdskI1g
Message-ID: <CAESVnVo9BqZaz7g5_m=ehjSq=kkqYv4Y8aRi5NbwDpLGaxVMLg@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] ZEND_ENGINE_2 define
From: pollita@php.net (Sara Golemon)

On Fri, Jan 2, 2015 at 2:30 PM, Kalle Sommer Nielsen <kalle@php.net> wrote:
> 2015-01-02 20:41 GMT+01:00 Sara Golemon <php@golemon.com>:
>> So instead you have to do:
>> #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
>>
>
> #ifdef ZEND_ENGINE_3
> # define ZEND_ENGINE_2
> #endif
>
Yeah, obviously I can do that.  I'm not actually an idiot, I just
disagree on which of two arbitrary choices seems more obvious.

And since we're pasting unnecessary pieces of obvious code, we could
as easily do:

#ifdef ZEND_ENGINE_3
# undef ZEND_ENGINE_2
#endif

Which leaves the decision to make the macros exclusive of each other
an arbitrary one.  Just as making them inclusive would have been
equally arbitrary.  But thank you for the unnecessary piece of obvious
code.

-Sara