Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80113
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me>
References: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me>
Date: Fri, 2 Jan 2015 20:50:06 -0800
Message-ID: <CAEZPtU79=VX1Scm6vVn-9iuHD=qqRoPMrsR4Ymqd9=QQeQbRCg@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints
From: pierre.php@gmail.com (Pierre Joye)

hi Andrea,

On Wed, Dec 31, 2014 at 12:27 PM, Andrea Faulds <ajf@ajf.me> wrote:
> Good evening,
>
> Parameter type hints for PHP=E2=80=99s scalar types are a long-requested =
feature for PHP. Today I am proposing an RFC which is a new attempt to add =
them to the language. It is my hope that we can finally get this done for P=
HP 7.
>
> I=E2=80=99d like to thank Dmitry, who emailed me and gave me some feedbac=
k on the draft RFC and some improvements to the patch. He encouraged me to =
put this to internals sooner rather than later, as it=E2=80=99s a feature m=
any people are hoping will be in PHP 7.
>
> The new RFC can be found here: https://wiki.php.net/rfc/scalar_type_hints
>
> As well as the RFC, there is a working Zend Engine III patch with tests, =
and an incomplete specification patch.
>
> Please read the RFC (and specification patch, if you wish) and tell me yo=
ur thoughts.


Thanks, great work and persistent effort!

As I am also slightly in favor of a strict way, this RFC is a good compromi=
se.

Some comments:

- on-numeric strings not accepted. Numeric strings with trailing
characters are accepted, but produce a notice.

I would rather not allow fancy conversions here. Any trailing non
white spaces characters should not be allowed. I know it is not what
PHP does now in some cases but this is really a fuzzy area and never
really matched any actual needs or usages.

I am also not a fan of errors, exception, at least for methods, make
much more sense. I know it is relatively easy to handle errors as
exception but still, let do it right now.

Cheers,
--=20
Pierre

@pierrejoye | http://www.libgd.org