Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80112 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17391 invoked from network); 2 Jan 2015 22:30:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Jan 2015 22:30:05 -0000 Authentication-Results: pb1.pair.com header.from=kalle.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=kalle.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.169 as permitted sender) X-PHP-List-Original-Sender: kalle.php@gmail.com X-Host-Fingerprint: 209.85.217.169 mail-lb0-f169.google.com Received: from [209.85.217.169] ([209.85.217.169:57675] helo=mail-lb0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 79/F1-04824-BEB17A45 for ; Fri, 02 Jan 2015 17:30:04 -0500 Received: by mail-lb0-f169.google.com with SMTP id p9so15487188lbv.14 for ; Fri, 02 Jan 2015 14:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=2FjR6W4zsyRvtVVDKf4hGlDJHKzHGPgN6k+tt6IOq44=; b=m8XvEw9BA4TJcsL3eUJxtemijdnVXFbbldjle/cU1oUkO+3JUNl/piSgtE3ET0Q2pw z4nZaXZ07QpyuWNRGnMzsUROvUI97SveYIYcyWCzynhIe6UZYIYvUxrSyqHd02RTeCQ+ zkmf/XK5WkNE7XxUiQuFrUE22ZmqYzp7GiVFHQaI5XjPtL7OkF9azsrTwaMElEJEyCvu jQ/BmiGguXHWbTDxy/rHamXbYRLCFUZqNVdv8xpQHYJiqgi8Ii6tFB2HGhL5vvuC/d8+ 10CIv79uPSuRCM6lLP1YdqFnceHH1Sn1KuLtxsxFC+8vLYjYx5JkHgUuR0EWIxC4pdIC Zp8Q== MIME-Version: 1.0 X-Received: by 10.112.14.6 with SMTP id l6mr79443384lbc.91.1420237800335; Fri, 02 Jan 2015 14:30:00 -0800 (PST) Sender: kalle.php@gmail.com Received: by 10.112.138.161 with HTTP; Fri, 2 Jan 2015 14:30:00 -0800 (PST) In-Reply-To: <3CB15CBB-8912-48E0-A3FF-6B0436F32616@golemon.com> References: <3CB15CBB-8912-48E0-A3FF-6B0436F32616@golemon.com> Date: Fri, 2 Jan 2015 23:30:00 +0100 X-Google-Sender-Auth: gxmzcWyulTNgfKZvn-52cB3YB0g Message-ID: To: Sara Golemon Cc: Andrea Faulds , Sara Golemon , PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] ZEND_ENGINE_2 define From: kalle@php.net (Kalle Sommer Nielsen) 2015-01-02 20:41 GMT+01:00 Sara Golemon : > So instead you have to do: > #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3) > #ifdef ZEND_ENGINE_3 # define ZEND_ENGINE_2 #endif in php_ext.h, like we had the following for 5.2 compatibles: #if PHP_VERSION_ID < 503000 # define zend_parse_parameters_none() zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "") #endif Bloilerplate code yes, but that is a small cost for cross version compatibility. Perhaps its time we have a php_compat.h header that is up to date for such we have in the main distro for all versions -- regards, Kalle Sommer Nielsen kalle@php.net