Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80097
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain seld.be designates 74.125.82.180 as permitted sender)
Message-ID: <54A6AAE8.6000202@seld.be>
Date: Fri, 02 Jan 2015 14:27:52 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Marco Pivetta <ocramius@gmail.com>
CC: PHP Internals List <internals@lists.php.net>
References: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me> <CAF+90c-uiLj1QoT+dXfd1obRXNcYcpBAJ-aU59yEXk+HYNZRFw@mail.gmail.com> <54A5DF14.7000105@gmail.com> <CAF+90c8g+vVC9YDSPrGTb-K+-KDwV1a1=8rf3BH-sHJYOh3TmA@mail.gmail.com> <CAFMT4NpGfew5qyrYFQ0qf8ATQf1ZH613VT9O7EosWJ=GA=q3ww@mail.gmail.com> <54A678EA.4070706@fischer.name> <54A6A4D3.9070808@seld.be> <CADyq6sKpvtBaatCA9HyeTOq4R8QBG4MQVeomdawczxYz77QnbA@mail.gmail.com>
In-Reply-To: <CADyq6sKpvtBaatCA9HyeTOq4R8QBG4MQVeomdawczxYz77QnbA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints
From: j.boggiano@seld.be (Jordi Boggiano)

On 02/01/2015 14:06, Marco Pivetta wrote:
> Regardless if this RFC gets through or not, changing the signature of a
> method IS a BC break in any case, so you shouldn't just move your `int`
> declaration from the docblocks into the method signature.

On public methods yes although a lot of internal public methods are 
probably safe-ish, or would only affect people extending/overriding.

Private methods though could still benefit from this perfectly safely, 
but if the public methods route params to private methods with strict 
hints you still get issues.

> I'm actually already using https://github.com/beberlei/assert for that,
> and I'd like to get rid of it for simpler types.

Interesting, I didn't know about this, and it's a cool way to get more 
specialized assertions than plain type hints allow. IMO with the RFC as 
it stands you could still get rid of it for simple types though because 
it's not your job to validate user input. You need an int ask for an int 
and get an int. If users like convenience they can skip validation, if 
they like strictness they can do their own layer of Assertion::foo calls 
in their controllers.

Cheers

-- 
Jordi Boggiano
@seldaek - http://nelm.io/jordi