Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80088
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.200 as permitted sender)
References: <CAESVnVrA_Z3cS2yYy7WStDaXib6PLnHUD6BXQSL3VL6pB6TUvA@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CAESVnVrA_Z3cS2yYy7WStDaXib6PLnHUD6BXQSL3VL6pB6TUvA@mail.gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-ID: <EB09BC7C-E3F9-44E9-8A5A-EE6DD0CA689E@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Date: Fri, 2 Jan 2015 11:18:23 +0000
To: Sara Golemon <pollita@php.net>
Subject: Re: [PHP-DEV] ZEND_ENGINE_2 define
From: ajf@ajf.me (Andrea Faulds)

Hey Sara,

> On 2 Jan 2015, at 05:24, Sara Golemon <pollita@php.net> wrote:
>=20
> I realize that ZE3 is not ZE2, but I always saw the ZEND_ENGINE_2
> define as more of a "At least ZE2" so that code of the form:
>=20
> #ifdef ZEND_ENGINE_2
>  newAPI();
> #else /* ZE1 */
>  oldAPI();
> #endif
>=20
> Would continue making sense (modulo newNewAPI() in ZE3, of course).
>=20
> Was the ZEND_ENGINE_2 define removed on purpose? Or as an accidental
> side-effect of a mass update to "We're ZE3 now!"

It was deliberate, I did it. The reason for getting rid of it was because it=
 makes checking ZE2 simpler, actually. I didn't want to have to do #if defin=
ed(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3).

Thanks.
--
Andrea Faulds
http://ajf.me/=