Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80041
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 74.125.82.177 as permitted sender)
References: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me>
In-Reply-To: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me>
MIME-Version: 1.0
Thread-Index: AQGEUxVom/MF8lo7irvbCgQdYKqgQJ1C1x4g
Date: Thu, 1 Jan 2015 14:41:06 +0200
Message-ID: <16d442a345cf2cbd4faac6d068c57343@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PHP-DEV] [RFC] Scalar Type Hints
From: zeev@zend.com (Zeev Suraski)

> -----Original Message-----
> From: Andrea Faulds [mailto:ajf@ajf.me]
> Sent: Wednesday, December 31, 2014 10:28 PM
> To: PHP Internals
> Subject: [PHP-DEV] [RFC] Scalar Type Hints
>
> Good evening,
>
> Parameter type hints for PHP=E2=80=99s scalar types are a long-requested =
feature
> for
> PHP. Today I am proposing an RFC which is a new attempt to add them to
> the language. It is my hope that we can finally get this done for PHP 7.

Andrea,


I like this draft too, and that's a first after countless proposals over th=
e
last decade - so kudos! :)

My main feedback here are the discrepancies between this RFC's casting rule=
s
and PHP's current built-in casting rules.  Ideally, I'd like those to be
completely identical and not almost-identical.
Since we're talking about v7.0, we do have the option of making changes to
PHP's fundamental casting rules where appropriate (e.g. converting an array
to a string).
But that said, I think the way strings->numbers are handled - where they
accept only numeric strings as it would mean you can't use casting to an
int/float as an ultra-simple way to sanitize untrusted input.  I would
change the =E2=80=A0 section from:

=E2=80=A0Non-numeric strings not accepted. Numeric strings with trailing ch=
aracters
are accepted, but produce a notice.
to
=E2=80=A0 Numeric strings with trailing characters and non-numeric strings =
are
accepted, but produce a notice.

- and apply it to both this RFC and the infrastructure convert_to_*(), so
that it applies across the board in PHP.

Zeev