Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80036 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 78752 invoked from network); 1 Jan 2015 00:34:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Jan 2015 00:34:06 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.49 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.192.49 mail-qg0-f49.google.com Received: from [209.85.192.49] ([209.85.192.49:56729] helo=mail-qg0-f49.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A9/E2-60454-DF594A45 for ; Wed, 31 Dec 2014 19:34:06 -0500 Received: by mail-qg0-f49.google.com with SMTP id a108so11744417qge.8 for ; Wed, 31 Dec 2014 16:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=BH2fXpn+tauGW1vQTRxxh7Az7mdZS4So8VZkvaATqi0=; b=pfvjXS1OiRwiGY/2MDQUCS2pV9Ueil8/oeQULxHeg2OR1xSQulVzzkuqPsrV/HSUiJ Ua7vrsEca6UEL1lKfAHBvM5tSy6gRAdouzhmsh+llrZ7bAN3WaU/o1n4fOzFV7PVlpYw DZ/WlSvmWwGNsFOtgEtaLw/fyjbpodT2dmgV7y9tECbiQAvSSjFYWz05I3gSP7gxpr3u VYfDn3UrgCxJgUybQhfD98zt7spsEWrW7RNHeWgd1FKtQN5e4633jRpDRhzAvUBL1wQq wajJxIxLxcLdBDGFN/fprJ0htffyi+futHN5hhqy3fFmDSCOWUX0j8kljS3bVZO1m5ML qnIQ== MIME-Version: 1.0 X-Received: by 10.224.79.212 with SMTP id q20mr114129967qak.4.1420072443246; Wed, 31 Dec 2014 16:34:03 -0800 (PST) Received: by 10.140.22.106 with HTTP; Wed, 31 Dec 2014 16:34:02 -0800 (PST) Received: by 10.140.22.106 with HTTP; Wed, 31 Dec 2014 16:34:02 -0800 (PST) In-Reply-To: <8B7FB652-77D4-499C-968E-3A3D48E98DA6@ajf.me> References: <002a01d02522$469637f0$d3c2a7d0$@tekwire.net> <8B7FB652-77D4-499C-968E-3A3D48E98DA6@ajf.me> Date: Wed, 31 Dec 2014 16:34:02 -0800 Message-ID: To: Andrea Faulds Cc: Nikita Popov , PHP internals , Dmitry Stogov , Xinchen Hui , francois@tekwire.net Content-Type: multipart/alternative; boundary=047d7bf1617e891528050b8c61d5 Subject: Re: [PHP-DEV] Merge HashTable and zend_array into a single data structure. From: pierre.php@gmail.com (Pierre Joye) --047d7bf1617e891528050b8c61d5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Jan 1, 2015 2:00 AM, "Andrea Faulds" wrote: > > Hey Fran=C3=A7ois, > > > On 31 Dec 2014, at 17:50, Fran=C3=A7ois Laupretre wrote: > > > > "Showing 46 changed files with 193 additions and 204 deletions". I am sorry but I can't analyze the impacts of your change, just from the patch. Did you write an RFC that would explain the impact, especially for extension writers ? > > Is that because of the patch=E2=80=99s size? 200+/- isn=E2=80=99t that bi= g for a patch. Well, size of a patch has no relation with the impact it could have. > > More generally, what is the rule ? Is there a list of people who can introduce changes in the code, and even BC breaks in the C API, without writing RFCs, or is it just a question of rights/karma on the source repository ? I say that because it is especially hard to have a proposed change accepted on the mailing list, as several 'watchdogs' are there to dismiss ideas coming from people they don't know. > > I don=E2=80=99t think there=E2=80=99s a hard and fast rule. We usually do= n=E2=80=99t worry as much about internal API and ABI breaks as we do about userland BC breaks, and in this case this is for a major version, so significant internal breakage is probably acceptable. Php7 breaks everything anyway, so no big deal here. However at least UPGRADING.INTERNALS should be done. A couple of things are already missing and it is going to be hard to keep it synced. Cheers, Pierre --047d7bf1617e891528050b8c61d5--