Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80033
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
Message-ID: <5073d81218a31808f01f7fa405eebc55.squirrel@webmail.klapt.com>
Date: Wed, 31 Dec 2014 23:21:36 +0100
To: internals@lists.php.net
Cc: "Pierre Joye" <pierre.php@gmail.com>
User-Agent: SquirrelMail/1.5.2 [SVN]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: resource consistency
From: anatol.php@belski.net ("Anatol Belski")

Hi,

related to bug #43525, I see that zend_fetch_resource() still expects a
default id as int as parameter. After some investigation i think that the
"int default_id" argument can be surely dropped from the signature. The
only extension in the core passing it is ext/interbase, all the others
pass -1. Any other zend_list_* signature expects no integer but a
zend_resource*.

What I would do instead - transfer the control over the defauld_id to the
corresponding extension. Maybe also making a helper function in
zend_list.c, if it proves itself as needed. But in any case, to be
consistent, the consistency should be that the api only works with
zend_resource *.

Please thoughts, I'd be inventing a patch if it's found sensible.

Regards

Anatol