Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:80031
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.43 as permitted sender)
Message-ID: <54A466CB.9020400@gmail.com>
Date: Wed, 31 Dec 2014 13:12:43 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Andrea Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>
References: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me>
In-Reply-To: <41D5BB0B-73AF-488E-968D-90B2878E3178@ajf.me>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

I like it, it's consistent and to the point. If we must have scalar
typed parameters (I'm not sure but if we do), IMO that's the way to do it.

The issue is the class names though. E.g. see:
https://github.com/ralphschindler/zf2-db/blob/master/research/ColumnType/Integer.php

and:

https://github.com/canaydogan/ObjectValidator/blob/master/src/ObjectValidator/Validator/Int.php

These are uppercase "I", but class names are not case-sensitive... So
we'll need to figure it out. Unfortunately, looking at github,
disallowing "class Int" looks like pretty bad idea. We can make it
lowercase-only, but this would be a bit weird since it's not sensitive
in all other places (unless we change that which is another huge can of
worms).

BTW, right now this code:

function foo(integer $a) { var_dump($a); }
foo(1);

produces this message:

Catchable fatal error: Argument 1 passed to foo() must be an instance of
integer, integer given

which is pretty confusing I'd say :) We'd probably want to rephrase that
message (yes, I know, patching all those tests yet again...)
-- 
Stas Malyshev
smalyshev@gmail.com