Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:80023 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 23535 invoked from network); 31 Dec 2014 11:12:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Dec 2014 11:12:21 -0000 Authentication-Results: pb1.pair.com header.from=jacob.bednarz@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jacob.bednarz@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.171 as permitted sender) X-PHP-List-Original-Sender: jacob.bednarz@gmail.com X-Host-Fingerprint: 209.85.192.171 mail-pd0-f171.google.com Received: from [209.85.192.171] ([209.85.192.171:52839] helo=mail-pd0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3B/A2-32362-41AD3A45 for ; Wed, 31 Dec 2014 06:12:20 -0500 Received: by mail-pd0-f171.google.com with SMTP id y13so20799210pdi.2 for ; Wed, 31 Dec 2014 03:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version :content-type; bh=Rjg/z+ezR28p3Nv1xXZxObG76kxy1sKPvgnbqdNDan0=; b=LY9UuZJ2NAqYqa/Ry+wYOpeW/031VqnZn9S5z0XfYBZxDJIx60Xg/67hLHYOhH6GA7 2dFvkGcgIIUbSKLiaVkaUqKS+EW4yhqcQi5YeSUmLLnfat27g1IP3B/3Sk4L9320QiGp VCZTHDk1OQxKWXFG/HanwhdR3lx/JXzp/S2ZP0YgLBTmqzDjigQ08YVWrtdUpQXrhTC3 X/VFnEuIjuJfH9XL8rMR1caFuIABIQYD4InweQ3WDecrcm0ricyDtKhKNRpLHV+Rft2Z 2Txng8ZrM2mJEnDpbmVi0eghgG6UOOf3KacngIr6PVkNnNdSUHeeqkkt1hcs08dUKlSL Wcog== X-Received: by 10.66.102.1 with SMTP id fk1mr25642415pab.16.1420024337411; Wed, 31 Dec 2014 03:12:17 -0800 (PST) Received: from [192.168.2.3] (CPE-124-177-114-162.lns5.woo.bigpond.net.au. [124.177.114.162]) by mx.google.com with ESMTPSA id wf5sm41264168pab.40.2014.12.31.03.12.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 31 Dec 2014 03:12:16 -0800 (PST) X-Google-Original-From: Jacob Bednarz Date: Wed, 31 Dec 2014 21:12:10 +1000 (AEST) To: internals@lists.php.net Message-ID: User-Agent: Alpine 2.11 (OSX 23 2013-08-11) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1422445466-1420024336=:27021" Subject: Preventing users from voting multiple times on a single bug From: jacob.bednarz@gmail.com (Jacob Bednarz) --0-1422445466-1420024336=:27021 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Hi, This is my attempt at a patch for a bug related to users being able to vote multiple times on the same bug (full report is at https://bugs.php.net/bug.php?id=51535). While this isn't a huge change I wanted to get confirmation on a few things before I went ahead so that I didn't break anything too badly. 1. Is this the correct list for changes related to bugs.php.net itself? If not, what is the correct mailing list for this change? 2. I see php-src has a defined coding standard however I wasn't able to see one for bugs.php.net so I have just gone with the standards that were already present near my changes. If there is a defined standards guideline which I have missed, feel free to direct me that way and I will check for any violations within my changes before this is merged. 3. Hannes was nice enough to give me some direction around getting my changes reviewed however with code changes is the preferred option to get review and merge it yourself? Or is there a release cycle? Or how does that aspect work? I've attached the patch and opened a pull request via GitHub (https://github.com/php/web-bugs/pull/13) for anyone that would like to review this one for me. Thanks again, Jacob. --0-1422445466-1420024336=:27021 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=51535-prevent-users-from-voting-multiple-times-on-same-bug.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=51535-prevent-users-from-voting-multiple-times-on-same-bug.patch RnJvbSA5MGIwN2FlZTQ5ZWE0MjI3YzgyZjgwYTAxMzZlMjE2OTUxMjY2MzNi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogSmFjb2IgQmVkbmFy eiA8amFjb2IuYmVkbmFyekBnbWFpbC5jb20+DQpEYXRlOiBXZWQsIDMxIERl YyAyMDE0IDA3OjQxOjU1ICsxMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIFByZXZl bnQgdXNlcnMgZnJvbSBhZGRpbmcgbXVsdGlwbGUgdm90ZXMgb24gYSBzaW5n bGUgYnVnDQoNCi0tLQ0KIHd3dy9idWcucGhwICB8ICAzICsrKw0KIHd3dy92 b3RlLnBocCB8IDEwICsrKysrKysrKysNCiAyIGZpbGVzIGNoYW5nZWQsIDEz IGluc2VydGlvbnMoKykNCg0KZGlmZiAtLWdpdCBhL3d3dy9idWcucGhwIGIv d3d3L2J1Zy5waHANCmluZGV4IGQ4ZjgzOTguLjRmNzM0NTUgMTAwNjQ0DQot LS0gYS93d3cvYnVnLnBocA0KKysrIGIvd3d3L2J1Zy5waHANCkBAIC02MDEs NiArNjAxLDkgQEAgc3dpdGNoICgkdGhhbmtzKQ0KIAljYXNlIDk6DQogCQlk aXNwbGF5X2J1Z19zdWNjZXNzKCdZb3UgaGF2ZSBzdWNjZXNzZnVsbHkgdW5z dWJzY3JpYmVkLicpOw0KIAkJYnJlYWs7DQorCWNhc2UgMTA6DQorCQlkaXNw bGF5X2J1Z19zdWNjZXNzKCdZb3UgaGF2ZSBhbHJlYWR5IHZvdGVkIG9uIHRo aXMgYnVnLicpOw0KKwlicmVhazsNCiANCiAJZGVmYXVsdDoNCiAJCWJyZWFr Ow0KZGlmZiAtLWdpdCBhL3d3dy92b3RlLnBocCBiL3d3dy92b3RlLnBocA0K aW5kZXggMTJkMmFjNS4uNTM2ZmY1NSAxMDA2NDQNCi0tLSBhL3d3dy92b3Rl LnBocA0KKysrIGIvd3d3L3ZvdGUucGhwDQpAQCAtNTUsNiArNTUsMTYgQEAg ZnVuY3Rpb24gZ2V0X3JlYWxfaXAgKCkNCiAkaXAgPSBpcDJsb25nKGdldF9y ZWFsX2lwKCkpOw0KIC8vIFRPRE86IGNoZWNrIGlmIGlwIGFkZHJlc3MgaGFz IGJlZW4gYmFubmVkLiBob3BlZnVsbHkgdGhpcyB3aWxsIG5ldmVyIG5lZWQg dG8gYmUgaW1wbGVtZW50ZWQuDQogDQorLy8gQ2hlY2sgd2hldGhlciB0aGUg dXNlciBoYXMgYWxyZWFkeSB2b3RlZCBvbiB0aGlzIGJ1Zy4NCiskYnVnX2No ZWNrID0gJGRiaC0+cHJlcGFyZSgiU0VMRUNUIGJ1ZywgaXAgRlJPTSBidWdk Yl92b3RlcyBXSEVSRSBidWcgPSA/IEFORCBpcCA9ID8gTElNSVQgMSIpDQor CS0+ZXhlY3V0ZShhcnJheSgkaWQsICRpcCkpDQorCS0+ZmV0Y2hSb3coKTsN CisNCitpZiAoIWVtcHR5KCRidWdfY2hlY2spKSB7DQorCS8vIExldCB0aGUg dXNlciBrbm93IHRoZXkgaGF2ZSBhbHJlYWR5IHZvdGVkLg0KKwlyZWRpcmVj dCgiYnVnLnBocD9pZD0kaWQmdGhhbmtzPTEwIik7DQorfQ0KKw0KIC8vIGFk ZCB0aGUgdm90ZQ0KICRkYmgtPnByZXBhcmUoIg0KIAlJTlNFUlQgSU5UTyBi dWdkYl92b3RlcyAoYnVnLGlwLHNjb3JlLHJlcHJvZHVjZWQsdHJpZWQsc2Ft ZW9zLHNhbWV2ZXIpDQotLSANCjIuMi4xDQoNCg== --0-1422445466-1420024336=:27021--