Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79961
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.48 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CABBJUpcbu1m7z1NZM-THwYgxAD9nANr0Yx-Y41Xxuga2ryhAfA@mail.gmail.com>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
	<946C1B1D-30B8-4029-A5A1-73D515A017D8@ajf.me>
	<1419428487.29904.6.camel@kuechenschabe>
	<CAEZPtU4_6uFjj1NWCjVhwcDSr2-94d+VW6JPoenXUFx=V=XS7Q@mail.gmail.com>
	<CAFMT4Nq-PdyJzfeZ8=FW6-CXZv6jDNYwhMTSRSKf6GaMuNwCVA@mail.gmail.com>
	<5E26F21C-EA41-43FF-8DDB-D0A985AB4197@ajf.me>
	<CAFMT4NoafZCLxsdaaUsBYp0t7xAWxdsjkFKUhXV_5-g34-TsRA@mail.gmail.com>
	<1419463624.28792.6.camel@kuechenschabe>
	<CAFMT4NqO8Z2AWsJxCJUWNvN6eAzT4foTojF4riGG4mZpUh4zWA@mail.gmail.com>
	<51160B8D-F662-458E-A0E0-1F37DC3A8869@ajf.me>
	<CAEZPtU7Jn_PHtAKbrYTXZm5GohA-qXq9M6+JnOt4OCUokRuuyA@mail.gmail.com>
	<CABBJUpd=+wUey1xLdC3+D-J9TspC+mARuWbTMDG4zALYA32KCA@mail.gmail.com>
	<CALJZF3iomGCVm-HytJAAoOttR7CeDvJ_bwQd2zk62yXv0aaoAw@mail.gmail.com>
	<CAFMT4No8hzPu05S8gHQG424zY0Mhri7OWuyYH=H7sVidS0fL6A@mail.gmail.com>
	<8F70E62C-FCB6-49F1-8F30-BD211BB050EA@ajf.me>
	<CABBJUpcbu1m7z1NZM-THwYgxAD9nANr0Yx-Y41Xxuga2ryhAfA@mail.gmail.com>
Date: Fri, 26 Dec 2014 17:04:04 -0700
Message-ID: <CAFMT4Nr9q7pnL+KaxZmNQMJL56mq-4Tj10QvE+_AQAnL3_Jrhg@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, Michael Wallner <mike@php.net>, 
	=?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	Pierre Joye <pierre.php@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: levim@php.net (Levi Morrison)

On Fri, Dec 26, 2014 at 5:42 AM, Xinchen Hui <laruence@php.net> wrote:
> Hey:
>
> On Fri, Dec 26, 2014 at 7:54 PM, Andrea Faulds <ajf@ajf.me> wrote:
>>
>>> On 26 Dec 2014, at 05:57, Levi Morrison <levim@php.net> wrote:
>>>
>>>> On Thu, Dec 25, 2014 at 2:33 PM, Michael Wallner <mike@php.net> wrote:
>>>> There's already ZEND_RESULT_CODE, or did I miss anything?
>>>
>>> According to lxr.php.net, this symbol ZEND_RESULT_CODE is not
>>> referenced in any place except its definition. We can begin using it
>>> if we like, or even rename it. Theoretically renaming it may break
>>> extensions; none that I could find reference it, though.
>>
>> Hey Levi,
>>
>> I think we should just rename it, it's a little too long. zend_status or ZEND_STATUS would be fine with me, preferably the former since we tend to use lowercase type names. Another possibility might be zend_result.
>>
> zend_status +1
>> If you folks like, I could go ahead and write a patch for master to rename it and use it in a bunch of places.
>
> great, thanks... please only added it to these functions who already
> use success/failure, don't change others :)

Here is a preliminary diff for a zend_status:
https://gist.github.com/morrisonlevi/04e9e20f5addadd656c3. It only
changes stuff in Zend/zend_API.{h,c} (except for the zend_status
definition in zend_types.h).