Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79952
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 57150 invoked from network); 26 Dec 2014 00:47:00 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Dec 2014 00:47:00 -0000
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.175 as permitted sender)
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 209.85.216.175 mail-qc0-f175.google.com  
Received: from [209.85.216.175] ([209.85.216.175:59109] helo=mail-qc0-f175.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A0/00-57071-300BC945 for <internals@lists.php.net>; Thu, 25 Dec 2014 19:47:00 -0500
Received: by mail-qc0-f175.google.com with SMTP id b13so7657129qcw.20
        for <internals@lists.php.net>; Thu, 25 Dec 2014 16:46:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=Z/sO+dehvjbA9c+LhJXEb1g0Xx6VqKchPbnqMleDupE=;
        b=es3fNPKc2dHGLslC1llH6lKamSzE07oH8Eyeq6FLpoHg2ixndJBEzxDqN4TtlSdB0i
         R/sYZQDzbjVKOgnunkzSpN4MuvESGbTq+a+l7AMV8QTl+3P0+1IMxqFxGq+D7ZyI47NL
         PNNeckiG7E+F4tU4jTH5ktIqrCgofMZIbYvb3nTp/pjON041Tg5K2xXL7a+P6lcV9dKR
         mP7qaJg+G0rJqgZQWxdYV7VaSRz6l9yAAxSEfGpAx83RGLAPUkswFmRaijLFmEnSP1k9
         uHbTrvxR46KSqR4mB+R/H7rkcDS+VTe78cv6M590H2UAX+/KFDWIrkMkj9CK1JPeWNxN
         mdqA==
MIME-Version: 1.0
X-Received: by 10.224.120.65 with SMTP id c1mr66389756qar.87.1419554816409;
 Thu, 25 Dec 2014 16:46:56 -0800 (PST)
Received: by 10.140.22.106 with HTTP; Thu, 25 Dec 2014 16:46:56 -0800 (PST)
In-Reply-To: <CALJZF3iomGCVm-HytJAAoOttR7CeDvJ_bwQd2zk62yXv0aaoAw@mail.gmail.com>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
	<946C1B1D-30B8-4029-A5A1-73D515A017D8@ajf.me>
	<1419428487.29904.6.camel@kuechenschabe>
	<CAEZPtU4_6uFjj1NWCjVhwcDSr2-94d+VW6JPoenXUFx=V=XS7Q@mail.gmail.com>
	<CAFMT4Nq-PdyJzfeZ8=FW6-CXZv6jDNYwhMTSRSKf6GaMuNwCVA@mail.gmail.com>
	<5E26F21C-EA41-43FF-8DDB-D0A985AB4197@ajf.me>
	<CAFMT4NoafZCLxsdaaUsBYp0t7xAWxdsjkFKUhXV_5-g34-TsRA@mail.gmail.com>
	<1419463624.28792.6.camel@kuechenschabe>
	<CAFMT4NqO8Z2AWsJxCJUWNvN6eAzT4foTojF4riGG4mZpUh4zWA@mail.gmail.com>
	<51160B8D-F662-458E-A0E0-1F37DC3A8869@ajf.me>
	<CAEZPtU7Jn_PHtAKbrYTXZm5GohA-qXq9M6+JnOt4OCUokRuuyA@mail.gmail.com>
	<CABBJUpd=+wUey1xLdC3+D-J9TspC+mARuWbTMDG4zALYA32KCA@mail.gmail.com>
	<CALJZF3iomGCVm-HytJAAoOttR7CeDvJ_bwQd2zk62yXv0aaoAw@mail.gmail.com>
Date: Fri, 26 Dec 2014 11:46:56 +1100
Message-ID: <CAEZPtU435oRr5u9_1OT-mMi-6JO9kdfh3quaVSNRiX_56ay-yg@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: Laruence <laruence@php.net>, =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	Levi Morrison <levim@php.net>, PHP internals <internals@lists.php.net>, Andrea Faulds <ajf@ajf.me>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: pierre.php@gmail.com (Pierre Joye)

On Fri, Dec 26, 2014 at 8:33 AM, Michael Wallner <mike@php.net> wrote:
> There's already ZEND_RESULT_CODE, or did I miss anything?

Yes, to read the thread :)

We are not talking about the lack of a status typedef but about the
inconsistencies across PHP internal APIs. And what Xinchen suggests
below is to begin by changing the functions signature from int to
status (aka ZEND_RESULT_CODE, see my previous code example) as a 1st
step.Functions returning 0/1/-1 themselves can be changed as a 2nd
step.

> On 25 Dec 2014 06:45, "Xinchen Hui" <laruence@php.net> wrote:

>> we can change these functions which use success/failure return
>> zend_status instead of int first.