Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79911
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <549A6D5A.6060307@gmail.com>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
	<946C1B1D-30B8-4029-A5A1-73D515A017D8@ajf.me>
	<CABBJUpcOXdK22FT9X1fMJuKD7ocdUOWoiJ=En8wSywqKXPL8Zw@mail.gmail.com>
	<549A6D5A.6060307@gmail.com>
Date: Wed, 24 Dec 2014 18:57:59 +1100
Message-ID: <CAEZPtU6217Tv0LonNytDg1-4G1MuPOeMMJLtYS29+Um-p6WFug@mail.gmail.com>
To: Stas Malyshev <smalyshev@gmail.com>
Cc: PHP internals <internals@lists.php.net>, Andrea Faulds <ajf@ajf.me>, Xinchen Hui <laruence@php.net>
Content-Type: multipart/alternative; boundary=001a11397ec076817a050af1a6d8
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: pierre.php@gmail.com (Pierre Joye)

--001a11397ec076817a050af1a6d8
Content-Type: text/plain; charset=UTF-8

On Dec 24, 2014 2:38 PM, "Stanislav Malyshev" <smalyshev@gmail.com> wrote:
>
> Hi!
>
> > But:  return 0 and return FAILURE... which is simpler?
>
> It's equally simple to write, but FAILURE of course is way simpler to
> understand when read.

I totally agree.

I do not care much about the value of failure or success but I am tired to
have to read the code to see if it is 0, 1, or -1 on failure.

The kind of uniformization I would like to see for the php internals APIs.

About the argument for the lack of info in function signature:

A simple typedef will solve it, for the good:

status php_foo();

Or something along this line.

Yes, it will mean yet another large set of changes for ext developers. But
at this point, it may be a good time to do it.

Cheers,
Pierre

--001a11397ec076817a050af1a6d8--