Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79908
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.217.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <946C1B1D-30B8-4029-A5A1-73D515A017D8@ajf.me>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
 <946C1B1D-30B8-4029-A5A1-73D515A017D8@ajf.me>
Date: Wed, 24 Dec 2014 13:18:05 +0800
Message-ID: <CABBJUpcOXdK22FT9X1fMJuKD7ocdUOWoiJ=En8wSywqKXPL8Zw@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: laruence@php.net (Xinchen Hui)

Hey:

  thanks, that is the first thought of mine too.

On Wed, Dec 24, 2014 at 1:06 PM, Andrea Faulds <ajf@ajf.me> wrote:
>
>> On 24 Dec 2014, at 03:25, Xinchen Hui <laruence@php.net> wrote:
>>
>> Hey:
>>
>>   We use SUCCESS/FAILURE as return value  in some APIs, but use
>> 0/1(false/true) in others.
>>
>>   I'd like to remove SUCCESS/FAILURE at all, use 0/1 instead..
>>
>>   what do you think?
>>
>> thanks
>
> Hi,
>
> Honestly, I don=E2=80=99t think SUCCESS and FAILURE are bad, they make it=
 explicit that some operation is taking place. But using int as the return =
type seems odd, maybe we could add some zend_ type for this, maybe an alias=
 of zend_bool?
>
> Similarly, though zend_uchar seems to be what=E2=80=99s used most of the =
time to store the return value of Z_TYPE(), maybe something like zend_type =
might be good.
>
> In fact, this is exactly what enums do, maybe we should use one:
>
> typedef enum _zend_success {
>     FAILURE =3D 0,
>     SUCCESS =3D 1
> } zend_success;
>
For now,  we can not tell what the function return to represent status
from the declaration , since they all return int.

     int func();

we have to looks into the source code to get what it used.

so change int func() to zend_success func() may help some bits.

But:  return 0 and return FAILURE... which is simpler?

thanks
> Thanks.
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/