Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79907
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ajf.me designates 192.64.116.216 as permitted sender)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
In-Reply-To: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
Date: Wed, 24 Dec 2014 05:06:14 +0000
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <946C1B1D-30B8-4029-A5A1-73D515A017D8@ajf.me>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: ajf@ajf.me (Andrea Faulds)


> On 24 Dec 2014, at 03:25, Xinchen Hui <laruence@php.net> wrote:
>=20
> Hey:
>=20
>   We use SUCCESS/FAILURE as return value  in some APIs, but use
> 0/1(false/true) in others.
>=20
>   I'd like to remove SUCCESS/FAILURE at all, use 0/1 instead..
>=20
>   what do you think?
>=20
> thanks

Hi,

Honestly, I don=E2=80=99t think SUCCESS and FAILURE are bad, they make =
it explicit that some operation is taking place. But using int as the =
return type seems odd, maybe we could add some zend_ type for this, =
maybe an alias of zend_bool?

Similarly, though zend_uchar seems to be what=E2=80=99s used most of the =
time to store the return value of Z_TYPE(), maybe something like =
zend_type might be good.

In fact, this is exactly what enums do, maybe we should use one:

typedef enum _zend_success {
    FAILURE =3D 0,
    SUCCESS =3D 1
} zend_success;

Thanks.
--
Andrea Faulds
http://ajf.me/