Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79905
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.54 as permitted sender)
Content-Type: text/plain;
	charset=gb2312
Mime-Version: 1.0 (1.0)
In-Reply-To: <50C312FD-B626-4CDF-B6E5-7EB625C28214@gmail.com>
Date: Wed, 24 Dec 2014 12:59:26 +0800
Cc: Xinchen Hui <laruence@php.net>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <46A21155-B3F2-4D56-91F1-C3F7ED1747B5@gmail.com>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com> <549A45BD.9050304@gmail.com> <50C312FD-B626-4CDF-B6E5-7EB625C28214@gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: laruence@gmail.com (Xinchen Hui)




> On Dec 24, 2014, at 12:55 PM, Xinchen Hui <laruence@gmail.com> wrote:
>=20
> Hey
>=20
>=20
>> On Dec 24, 2014, at 12:49 PM, Stanislav Malyshev <smalyshev@gmail.com> wr=
ote:
>>=20
>> Hi!
>>=20
>>> Hey:
>>>=20
>>>  We use SUCCESS/FAILURE as return value  in some APIs, but use
>>> 0/1(false/true) in others.
>>>=20
>>>  I'd like to remove SUCCESS/FAILURE at all, use 0/1 instead..
>>>=20
>>>  what do you think?
>>=20
>> I think it would make reading code harder. Why do it - is there any
>> benefit in it? SUCCESS/FAILURE is a
yes=A3=AC to be consistent

We have functions all return int

But some is them use success (0) some of them use bool true(1)

That will lead to hard to write codes
Thanks
>> good way to indicate - well, success
>> and failure. Replacing it with meaningless numbers would make code
>> harder to read and harder to write without mistakes.
> I think if(func()) is better, more readeable than if(func() =3D=3D success=
)
>=20
> Thanks
>> --=20
>> Stas Malyshev
>> smalyshev@gmail.com