Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:79902
Return-Path: <smalyshev@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 15146 invoked from network); 24 Dec 2014 04:49:08 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Dec 2014 04:49:08 -0000
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@gmail.com
X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com  
Received: from [209.85.214.170] ([209.85.214.170:48448] helo=mail-ob0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id B2/80-10609-2C54A945 for <internals@lists.php.net>; Tue, 23 Dec 2014 23:49:07 -0500
Received: by mail-ob0-f170.google.com with SMTP id wp18so28124932obc.1
        for <internals@lists.php.net>; Tue, 23 Dec 2014 20:49:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        bh=EL6TBLDbBFpYAX9Lm+IwVkNM1WQYZAb8dH7Uk9vBVA0=;
        b=rA1O6MkCAimFg7Ie5Td3bFOa2f9BQdbQKIl9z24GVUAo15go9eZALqTQfG7BOO6bgr
         3gcahHtHeEsS1n4kI7NwvTd8LZC0A0HkgMaiKSERGRleL8OS0oIVmIgGisHPx+kub23d
         46gkSiwAsdRy9jRG9IF6uTSeAIPlcPbSFwc2VJOieXOZY19zEza/syYHkBD3lbzETFl+
         d8jqNd9dWCPqQVMk1C9eIgBr8oVGigznnr/aAg4agx18sQyHPSHRdz3OzSBCCaJyVAJJ
         hcm3VKGfBHC04VGKcncVhxGuzQoHi0d6gPCUM2UZidyhuXQdESIkGQkowgBpuu/8iBOl
         hr9w==
X-Received: by 10.202.81.19 with SMTP id f19mr17546005oib.45.1419396543588;
        Tue, 23 Dec 2014 20:49:03 -0800 (PST)
Received: from [192.168.2.145] (108-66-6-48.lightspeed.sntcca.sbcglobal.net. [108.66.6.48])
        by mx.google.com with ESMTPSA id n66sm11475845oig.2.2014.12.23.20.49.02
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 23 Dec 2014 20:49:02 -0800 (PST)
Message-ID: <549A45BD.9050304@gmail.com>
Date: Tue, 23 Dec 2014 20:49:01 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Xinchen Hui <laruence@php.net>, 
 PHP Internals <internals@lists.php.net>
References: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
In-Reply-To: <CABBJUpdWefmJAYK7rmwJ09kEVRvdLV8ruLJuLJMyM7W3Z8Z2Jw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] About SUCCESS/FAILURE
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Hey:
> 
>    We use SUCCESS/FAILURE as return value  in some APIs, but use
> 0/1(false/true) in others.
> 
>    I'd like to remove SUCCESS/FAILURE at all, use 0/1 instead..
> 
>    what do you think?

I think it would make reading code harder. Why do it - is there any
benefit in it? SUCCESS/FAILURE is a good way to indicate - well, success
and failure. Replacing it with meaningless numbers would make code
harder to read and harder to write without mistakes.
-- 
Stas Malyshev
smalyshev@gmail.com