Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:79853 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99656 invoked from network); 21 Dec 2014 16:29:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Dec 2014 16:29:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=dragoonis@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dragoonis@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.47 as permitted sender) X-PHP-List-Original-Sender: dragoonis@gmail.com X-Host-Fingerprint: 209.85.216.47 mail-qa0-f47.google.com Received: from [209.85.216.47] ([209.85.216.47:58009] helo=mail-qa0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3B/C3-08160-F75F6945 for ; Sun, 21 Dec 2014 11:29:52 -0500 Received: by mail-qa0-f47.google.com with SMTP id n4so2457257qaq.34 for ; Sun, 21 Dec 2014 08:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=j8DaFGZQxiZZJrm0iN0quSBEcXfT4w+1Fvktogxr5DA=; b=OUIz29kHIfeJzn4au0UoAP64J/+MjS7zFOzPqlhpAEuv24qtOULYOLFu79Z5N8DMt0 2EM4NeGOeWjRBwzf61V0GipX7QFyKlLfTXDzUlCHlJCglUd9pdVAXIxXlpKho+1ljbyW FykYY52YHqp6lgS9qBgvssCQojeOgFpq1JSDILqRneydU0ydzod0ntCnNud9E55i5t93 v9XaLGJ4x0eRttMpXeILUQk6thrdxWErCaj41+TlTThGrYECbH4TJYDss911RiroQ1Je Y9pcCVW8HQDsEH/T8tCTpFn9d82qQvDCZ2eIW22plH0TdrNzmdDBVgz1b+1xvDR9GJMV G89g== MIME-Version: 1.0 X-Received: by 10.224.164.195 with SMTP id f3mr30837603qay.55.1419179388839; Sun, 21 Dec 2014 08:29:48 -0800 (PST) Received: by 10.229.174.6 with HTTP; Sun, 21 Dec 2014 08:29:47 -0800 (PST) Received: by 10.229.174.6 with HTTP; Sun, 21 Dec 2014 08:29:47 -0800 (PST) In-Reply-To: References: <2F9B99EF-538C-4225-95A4-943F57DADF69@ajf.me> <97FF25C5-E881-4E53-A86A-3688BEE031FD@ajf.me> Date: Sun, 21 Dec 2014 16:29:47 +0000 Message-ID: To: Andrea Faulds Cc: PHP Internals List Content-Type: multipart/alternative; boundary=089e01538190582f59050abc7352 Subject: Re: [PHP-DEV] Re: [PATCH] Consistent type names in error messages From: dragoonis@gmail.com (Paul Dragoonis) --089e01538190582f59050abc7352 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 21 Dec 2014 13:25, "Andrea Faulds" wrote: > > > > On 20 Dec 2014, at 15:50, Andrea Faulds wrote: > > > > > >> On 14 Dec 2014, at 18:35, Andrea Faulds wrote: > >> > >> I=E2=80=99ve made a patch which makes zend_parse_parameters and userla= nd type hints consistently show =E2=80=9Cinteger=E2=80=9D and =E2=80=9Cfloat=E2=80= =9D rather than =E2=80=9Clong=E2=80=9D and =E2=80=9Cdouble=E2=80=9D: https://github.com/php/php-src/pull/955 > >> > >> I also wrote a GNU sed script which I used to update the tests: https://gist.github.com/TazeTSchnitzel/c0d780466def9f226318 > > > > Hi, > > > > Is anyone here opposed to this, or should I just merge it? I don=E2=80= =99t think it really needs an RFC. It doesn=E2=80=99t break BC. > > > > Thanks. > > Hey, > > I=E2=80=99ve merged the patch into master, PHP 7 will have consistent typ= e names in its error messages. :) Thanks for the patch and the other contribs you've been doing lately. > > Thanks. > -- > Andrea Faulds > http://ajf.me/ > > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > --089e01538190582f59050abc7352--